267237 - No titlebar text when <title> longer than 475 characters

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Felix Miata]

This was tested in 2004103108 & 2004102908 OS/2 trunk. Normal title text
observed testing in Linux trunk & OS/2 FF1.0PR & 1.7.3.

Text of subject URL when bug 266270 found:
once inside this real estate professionals MLS site, virtually none of the java
based scripts work at all. I have tried all current versions of explorer,
safari, firefox. Typical microsoft non-standard implementation of java. Why
can't we have a version of Java, in a browser, that supports the Microsoft
flavor? None of my colleagues on PC's have any trouble with this site at all.
It's password protected so not much checking you can do. I could email the
source code from a few of the more troubled pages.

To reproduce:
Load indicated URL

Actual results:
Titlebar shows no characters

Expected results:
Titlebar shows whatever portion of <title> that fits in the available space

Comment 1

[Felix Miata]

Attachment: screenshot

Comment 2

[Felix Miata]

Attachment: testcase

Comment 3

[Alexander Opitz]

It is/was the titel og bug 266770 but the bug isn't related ;)

Comment 4

[Mike Kaply [:mkaply]]

Was this a regression?

The testcase is working on my machine

Comment 5

[Mike Kaply [:mkaply]]

This is a funny one.

Clearly in the code, we have a value MAX_TITLEBAR_LENGTH which we were using.

when we checked in bug 189480, we dropped that check.

oops

Comment 6

[Felix Miata]

With dearth of recent OS/2 trunk builds available, finding a regression date on
this could be major difficult. I never saw a long <title> until bug 266770.
IIRC, I was was using the 27 Oct build at the time I noticed this. Between then
and late Sept, I captured only 24 Oct and 18 Oct. 18 was unusable, and I didn't
even find 24 until I found 27. Basically until 27, I was using Peter's 1.8a4,
which along with 18 & 24 I did not test for this bug.

Comment 7

[Mike Kaply [:mkaply]]

Attachment: Fix

Truncate to 256 chars

Comment 8

[Mike Kaply [:mkaply]]

Fix checked in everywhere.

a=mkaply for all.

Comment 9

[Felix Miata]

fix verified in 2004110412 trunk