267302 - Views should be created by the view manager

Status: RESOLVED FIXED

(Core :: Web Painting, defect)

Description

[[e-mail]]

Currently views are created by the component manager. This is a hack that
depends on the component manager being able to call QueryInterface on a view,
thinking that it implements nsISupports. Instead the view manager should create
and initialize views directly.

Comment 1

[[e-mail]]

Attachment: Remove NS_VIEW_CID

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

   { "Scroll Port View", NS_SCROLL_PORT_VIEW_CID,
     "@mozilla.org/scroll-port-view;1", nsScrollPortViewConstructor },
 
can you remove this too?

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

also, is nsIView::Init still needed?

Comment 4

[[e-mail]]

(In reply to comment #2)
>    { "Scroll Port View", NS_SCROLL_PORT_VIEW_CID,
>      "@mozilla.org/scroll-port-view;1", nsScrollPortViewConstructor },
>  
> can you remove this too?
Not yet, but I can roll it into the patch...

(In reply to comment #3)
> also, is nsIView::Init still needed?
No, I'll remove that at the same time.

Comment 5

[[e-mail]]

Attachment: Proposed patch

OK, so now I've fixed up scrollable and placeholder views too.
I've also removed a few includes that are no longer used.

Note that ViewWrapper still uses of nsIView::QueryInterface; the other callers
need to be replaced by nsIView::GetScrollableView (or IsScrollableView or
whatever the flavour of the month is).

Comment 6

[[e-mail]]

Oh wait, I'll need to rev some IIDs too, sigh...

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 164373 [details] [diff] [review]
Proposed patch

bump the IIDs

Comment 8

[[e-mail]]

Fix checked in.

Comment 9

[Jasper]

Seems that Camino has started to have some serious scrolling issues after this
bug was fixed. A separate Camino bug was filed to track what happened, Bug Bug
268218.