Closed Bug 267302 Opened 15 years ago Closed 15 years ago

Views should be created by the view manager

Categories

(Core :: Web Painting, defect)

defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: neil, Assigned: neil)

Details

Attachments

(2 files)

Currently views are created by the component manager. This is a hack that
depends on the component manager being able to call QueryInterface on a view,
thinking that it implements nsISupports. Instead the view manager should create
and initialize views directly.
Assignee: roc → neil.parkwaycc.co.uk
Status: NEW → ASSIGNED
Attachment #164280 - Flags: superreview?(roc)
Attachment #164280 - Flags: review?(roc)
   { "Scroll Port View", NS_SCROLL_PORT_VIEW_CID,
     "@mozilla.org/scroll-port-view;1", nsScrollPortViewConstructor },
 
can you remove this too?
also, is nsIView::Init still needed?
(In reply to comment #2)
>    { "Scroll Port View", NS_SCROLL_PORT_VIEW_CID,
>      "@mozilla.org/scroll-port-view;1", nsScrollPortViewConstructor },
>  
> can you remove this too?
Not yet, but I can roll it into the patch...

(In reply to comment #3)
> also, is nsIView::Init still needed?
No, I'll remove that at the same time.
Attached patch Proposed patchSplinter Review
OK, so now I've fixed up scrollable and placeholder views too.
I've also removed a few includes that are no longer used.

Note that ViewWrapper still uses of nsIView::QueryInterface; the other callers
need to be replaced by nsIView::GetScrollableView (or IsScrollableView or
whatever the flavour of the month is).
Attachment #164373 - Flags: superreview?(roc)
Attachment #164373 - Flags: review?(roc)
Oh wait, I'll need to rev some IIDs too, sigh...
Comment on attachment 164373 [details] [diff] [review]
Proposed patch

bump the IIDs
Attachment #164373 - Flags: superreview?(roc)
Attachment #164373 - Flags: superreview+
Attachment #164373 - Flags: review?(roc)
Attachment #164373 - Flags: review+
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Seems that Camino has started to have some serious scrolling issues after this
bug was fixed. A separate Camino bug was filed to track what happened, Bug Bug
268218.
Component: Layout: View Rendering → Layout: Web Painting
You need to log in before you can comment on or make changes to this bug.