267421 - Updates to the he-IL l10n

Status: RESOLVED FIXED

(Mozilla Localizations :: he / Hebrew, defect)

Description

[Asaf Romano (gone)]

Comment 1

[Asaf Romano (gone)]

Attaching diffs and zips from reuven changes

Comment 2

[Asaf Romano (gone)]

Attachment: Browser Patch

Other than the auto-henerate dates, this one disbales accesskeys (as disscused
in #l10n) and updates some strings.

Comment 3

[Asaf Romano (gone)]

Attachment: toolkit patch

Again, other than MT auto-generated dates, this fixes some strings etc.

Comment 4

[Asaf Romano (gone)]

Attachment: Partial help l10n

Comment 5

[Asaf Romano (gone)]

Attachment: Inspector l10n

Comment 6

[Benjamin Smedberg]

Comment on attachment 164354 [details] [diff] [review]
toolkit patch

Please avoid committing files where only the date changed. Only commit the ones
where there were substantive changes.

Comment 7

[Benjamin Smedberg]

Comment on attachment 164355 [details]
Partial help l10n

You know, of course, that with the help and DOMI files you need to add
LOCALE_HAS_DOMI and LOCALE_HAS_HELP to browser...defines.inc and set up
extra-jar.mn to ship the help files.

Comment 8

[Asaf Romano (gone)]

Comment on attachment 164355 [details]
Partial help l10n

Reuven: as mention on phone call, please do not checkin help l10n for 1.0.

Comment 9

[Reuven Gonen]

Attachment: bookmarks patch

I modified the bookmarks file for removing the "Firefox Hebrew Crew Picks" and
replacing "update" with "addons" for the mozilla update.

Comment 10

[Axel Hecht]

I'd be ok with attachement 175018, but sairuh signed that off in
bug 283325 comment 37, so IMHO, it's up to her.

Comment 11

[sairuh (rarely reading bugmail)]

hm, I'm not sure if we're taking additional checkins for 1.0.1 l10n builds which
I had verified --cc'ing cbeard, cmp and rebron for the official word there.

Comment 12

[Zibi Braniecki [:zbraniecki][:gandalf]]

we still did not release he-IL. I'm also positive about this patch and I can
give a+ and check it in if sairuh is OK about it.

Comment 13

[sairuh (rarely reading bugmail)]

to be honest, I think Chase, Asa, Chris or Rafael would be the ones to approve
this change --I don't know what the best process is here. but if they say it's
okay, that's great.

Comment 14

[Asa Dotzler [:asa]]

We're not taking any l10n changes into 1.0.1 builds if the builds shipped in 1.0. 

Comment 15

[Chase Phillips]

Comment on attachment 175018 [details] [diff] [review]
bookmarks patch

Overall I'm minusing.  Re: the update.m.o -> addons.m.o link, if we change this
for one locale, we'll have to change it for all, and we're fine with it being
update.mozilla.org right now.

As for removing crew picks, it's a good idea to make that change.  Redo the
patch without the update.m.o change and then resubmit.	For 1.0.1, we're going
to ship the version in aviary1.0.1-l10n-candidates-deuce.  Having the removed
crew picks will help us for a possible 1.0.2 and later in 1.1.

Comment 16

[Asaf Romano (gone)]

FYI, we haven't shiped "craw picks" in the heIL 1.O... The he-il build (with the
fixed theme) included the fix for bookmarks.html.

Comment 17

[Reuven Gonen]

Attachment: updated bookmarks diff

i'm attaching the updated bookmark diff file without the "addons" change.

Comment 18

[Asa Dotzler [:asa]]

Is this bug still pending a review or has it been resolved?

Comment 19

[Tsahi Asher]

reuven, you need to remove all the icon= and last_visit= from attachment 176013 [details] [diff] [review]
(the last one).

Comment 20

[Asa Dotzler [:asa]]

Comment on attachment 176013 [details] [diff] [review]
updated bookmarks diff

not approved until the changes are made to remove icon= and lastupdate. please
re-request when you've updated the patch. Thanks.

Comment 21

[Reuven Gonen]

Attachment: rearrange credits by last name

for some reason i ordered the hebrew contributors credits by first name. this patch rearranges the list by last name.

this patch was tested and contains apparently no risk.

Comment 22

[Axel Hecht [:Pike]]

Comment on attachment 202926 [details] [diff] [review]
rearrange credits by last name

Too late for nits. The tree is frozen, we're only taking *really* important changes.

Do you ever close bugs or is this bug supposed to turn into a never ending and confusing story?