--enable-quantify configure option should imply /OPT:NOICF

RESOLVED FIXED

Status

Product:
SeaMonkey
Component:
Build Config
RESOLVED FIXED
Reported:
14 years ago
Modified:
14 years ago

People

(Reporter: Brian Ryner (not reading), Assigned: Brian Ryner (not reading))

Tracking

Version:
Trunk
x86
Windows XP

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

patch
826 bytes, patch
dbaron
: review+
Details | Diff | Splinter Review
(Assignee)

Description

•
14 years ago 
The ICF optimization in the MSVC linker allows it to point identical methods at
the same address, which is a code size savings.  However, this is bad for
Quantify, since you don't know which of the methods was actually called.  So I
think we should turn this optimization off when using --enable-quantify.
 (Assignee)

Updated

•
14 years ago
Attachment #164500 - Flags: review?(dbaron)

Comment 2

•
14 years ago 
Brendan might want this off unconditionally -- I remember him complaining about
function pointer equality a while back -- I'm not sure how he solved the bug in
question.
Attachment #164500 - Flags: review?(dbaron) → review+
 (Assignee)

Comment 3

•
14 years ago 
checked in
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.