267576 - --enable-quantify configure option should imply /OPT:NOICF

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Brian Ryner (not reading)]

The ICF optimization in the MSVC linker allows it to point identical methods at
the same address, which is a code size savings.  However, this is bad for
Quantify, since you don't know which of the methods was actually called.  So I
think we should turn this optimization off when using --enable-quantify.

Comment 1

[Brian Ryner (not reading)]

Attachment: patch

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Brendan might want this off unconditionally -- I remember him complaining about
function pointer equality a while back -- I'm not sure how he solved the bug in
question.

Comment 3

[Brian Ryner (not reading)]

checked in