267723 - ViewSource doesn't scroll to the selected line when opened from JS Console links; ViewSource->Edit->Go to Line broken as well; works in 1.0PR

Status: RESOLVED FIXED

(Toolkit :: View Source, defect)

Description

[Steffen Wilberg]

Clicking on a link in the js console opens View Source but don't scroll the the
right line. Go to Line is broken as well.

The js console displays:
Error: ds has no properties
Source File: chrome://global/content/findBar.js
Line: 209

That's the 'var display' line:
  function getSelectionController(ds)
  {
    var display =
ds.QueryInterface(Components.interfaces.nsIInterfaceRequestor).getInterface(Components.interfaces.nsISelectionDisplay);
    if (!display)
      return null;
    return display.QueryInterface(Components.interfaces.nsISelectionController);
  }

Comment 1

[Steffen Wilberg]

There's a getSelectionController in both viewSource.js and findBar.js, both
referenced by viewSource.xul. The latter expects the docshell as argument. So we
need to either add
  if (!ds)
    ds = getBrowser().docShell;
to the one in findBar.js or rename one of the functions.

Comment 2

[Steffen Wilberg]

Attachment: rename

renames getSelectionController to getSelectionControllerFromDS in findBar.js.

The find bar and find-as-you-type still work elsewhere, including highlight.

Comment 3

[Steffen Wilberg]

Comment on attachment 164589 [details] [diff] [review]
rename

This is a regression from 1.0 PR and should be fixed before 1.0.

Comment 4

[Steffen Wilberg]

Attachment: rename

Comment 5

[Steffen Wilberg]

Comment on attachment 164591 [details] [diff] [review]
rename

This is the right patch.

Comment 6

[Steffen Wilberg]

better summary.

Comment 7

[Ben Goodger (use ben at mozilla dot org for email)]

Use something like "getSelectionControllerForFindToolbar" or something related
to the actual use, not what it's doing, to make the code more readable and
sr+a=[e-mail]. No need to attach a new patch make that change and land!

Comment 8

[Steffen Wilberg]

Checked in branch with "getSelectionControllerForFindToolbar".
Trunk doesn't have the find toolbar stuff yet.