Closed Bug 267839 Opened 20 years ago Closed 20 years ago

Use $< and $@ where appropriate

Categories

(NSS :: Build, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: wtc, Assigned: wtc)

Details

Attachments

(1 file)

I reviewed coreconf/rules.mk and found several places where we should use the $< and $@ special variables. Here are the definitions of the relevant special variables. $@ The file name of the target of the rule $< The name of the first prerequisite $* In a static pattern rule, $* is the part of the file name that matched the '%' in the target pattern.
Attached patch Proposed patchSplinter Review
Attachment #164670 - Flags: review?(rrelyea0264)
Attachment #164670 - Flags: review?(rrelyea) → review+
I checked in this patch on the NSS trunk (NSS 3.10). Checking in rules.mk; /cvsroot/mozilla/security/coreconf/rules.mk,v <-- rules.mk new revision: 1.59; previous revision: 1.58 done Portions of this patch were checked in in rev. 1.57.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.10
Setting priorities on unprioritized bugs resolved fixed for NSS 3.10.
Priority: -- → P3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: