268168 - [mozTXTToHTMLConv] "x^2" text to html conversion is broken for non-integer powers and is not implemented for negative powers

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Hans-Andreas Engel]

When a text/plain message is displayed, "^" is interpreted as "power" and is
displayed as "<sup>..</sup>" where appropriate.  The current implementation is
somewhat incomplete/broken.

a) O.k.: "x^2" is displayed as "x<sup>2</sup>".

b) Broken: "x^0.5" is displayed as "x<sup>0</sup>.5", however "x<sup>0.5</sup>"
would be correct.

c) Not implemented: "x^-2" is displayed as is, while ""x<sup>-2</sup>" would be
nicer.


To test this behavior, compose the following message and save it as Draft (as
text/plain; if text/html is your default message format hold "Shift" while
pressing the "Compose" button).
   Use <sup> for x^2, x^-2, x^0.5; use "<sup>2</sup>" for x^2-1 and x^2.
   Do not use <sup> for x^b, x^2y etc.

Comment 1

[Hans-Andreas Engel]

The relevant code is at
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/netwerk/streamconv/converters/mozTXTToHTMLConv.cpp&rev=1.76&root=/cvsroot#931

Comment 2

[Hans-Andreas Engel]

Attachment: Proposed patch, fixes cases b) and c)

Also converts [f(x)+y]^2, {f[g(x)]+y}^2  [not only (x+y)^2] to
"...<sup>2</sup>".

Comment 3

[Darin Fisher]

Comment on attachment 164966 [details] [diff] [review]
Proposed patch, fixes cases b) and c)

please re-request sr from me once you have a r+ from ben (or some other
qualified reviewer)

Comment 4

[Ben Bucksch (:BenB)]

Comment on attachment 164966 [details] [diff] [review]
Proposed patch, fixes cases b) and c)

r=BenB

thanks for the well-written patch

Comment 5

[Darin Fisher]

Comment on attachment 164966 [details] [diff] [review]
Proposed patch, fixes cases b) and c)

sr=darin

Comment 6

[Hans-Andreas Engel]

Thank you for the efficient reviewing process!

I do not have CVS write access, so everyone should feel free to checkin this patch. 

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

timeless just landed this fix: Bug 268168 [mozTXTToHTMLConv] "x^2" text to html
conversion is broken for non-integer powers and is not implemented for negative
powers
patch by [e-mail] r=benb sr=darin