Closed Bug 268722 Opened 20 years ago Closed 20 years ago

[firefox] es-ES build still contains old Firefox Crew Picks bookmarks

Categories

(Mozilla Localizations :: es-ES / Spanish, defect)

Product:
Mozilla Localizations
Component:
es-ES / Spanish
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: bugzilla, Assigned: omgs)

Details

Attachments

(1 file, 5 obsolete files)

bookmarks file inluding pike's comments
17.31 KB, text/html
axel
: approval-aviary+
Details 
found using recent (20041108) Firefox 1.0 es-ES builds on all platforms. when
you create a new profile, the default bookmarks contains a folder of the old
Crew Picks links which should be removed --or at least changed to better fit the
needs of the localized build.

in the en-us build (and many other locales), this was addressed in bug 266457.
Flags: blocking-aviary1.0-L10N?
This sounds joking. The bookmarks.html was right taken from en-US directory,
without modifying anything to avoid problems, and now that file is invalid.
Well, take the current en-US and replace the "wrong" one. I can't do this myself
since I don't have cvs write access.
We had a late change in the en-US bookmarks where we couldn't ship what we had.
 We didn't do a good job of communicating that change.
(In reply to comment #1)
> This sounds joking. The bookmarks.html was right taken from en-US directory,
> without modifying anything to avoid problems, and now that file is invalid.
> Well, take the current en-US and replace the "wrong" one. I can't do this myself
> since I don't have cvs write access.

I wouldn't approve that. I would be suprised to see us signing off any unlocalized
bookmarks file.
There are a few links that need to be done by the localizer, esp the community 
support one in the Mozilla and Firefox links. Other mozilla.org links should point
to localized versions, too, most likely on mozilla-europe.org.
Attached file Bookmarks with crew removed (obsolete) — 
This a is a bookmarks file with the crew branch removed. I hope this is ok to
include as a valid bookmarks file.
Is this resolved? If so, can someone please resolve this bug?
hm, I still see the Crew Picks bookmarks. tested with linux installer bits from
2004-11-22.
This is the previous bookmarks.html almost fully translated. Main modifications
besides translation and replacing google.com with google.es are:

- replaced dictionary.com with drae.es, the website for Spanish Royal Academy
of Language
- kept original english search for slang, as no equivalent service has been
found in spanish
- added (instead of replacing) link to http://difundefirefox.com/, a
non-official spanish website done to reflect SpreadFirefox.

Please, Oscar, check this bookmarks.html and, if you agree with it, state your
approval here so the bug can be closed and es-ES localized version may be
shipped.
Comment on attachment 166129 [details]
Bookmarks with crew removed

This is obsolete by attachment 166878 [details]
Attachment #166129 - Attachment is obsolete: true
I bless Ricardo's attachment and mark previous as obsolete, so please proceed
and finish with this nightmare.
Comment on attachment 166878 [details]
Fully translated proposed bookmarks.html

You need to set the approval-aviary flag on the patch to get approval. I doubt
anything will happen if you don't.
Attachment #166878 - Flags: approval-aviary?
Comment on attachment 166878 [details]
Fully translated proposed bookmarks.html

approval-aviary -

http://www.mozilla-europe.org/es/products/firefox/
is a bad url and afair 
http://fxfeeds.mozillazine.org/ too.

Rebron said he'll be bugging es-ES owner about it.
Attachment #166878 - Flags: approval-aviary? → approval-aviary-
What do you mean with "http://www.mozilla-europe.org/es/products/firefox/" is a
bad url? This URL works perfectly here.

http://fxfeeds.mozillazine.org/ is indeed wrong, it should be
http://fxfeeds.mozilla.org/
(In reply to comment #11)
> (From update of attachment 166878 [details])
> approval-aviary -
> 
> http://www.mozilla-europe.org/es/products/firefox/
> is a bad url


Sorry, but that URL is used in two different bookmarks (set after the english
ones of the first attachment):

Bookmarks Toolbar Folder -> "Comenzar con Firefox"
Enlaces Firefox y Mozilla -> "Página principal de Firefox en Mozilla Europa"

Should I replace both occurences, or just one of them? In the second case, which
one?


'Comenzar con Firefox' should probably be
http://www.mozilla-europe.org/es/products/firefox/start/central.html. I think
'Página de inicio de Firefox' should be http://start.mozilla.org/firefox. You
don't seem to have 'Firefox Central' that the English one
(http://lxr.mozilla.org/aviarybranch/source/browser/locales/en-US/profile/bookmarks.html)
has under 'Firefox and Mozilla Links', if you add it it should point to
http://www.mozilla-europe.org/es/products/firefox/start/central.html.
(In reply to comment #16)
> 'Comenzar con Firefox' should probably be
> http://www.mozilla-europe.org/es/products/firefox/start/central.html. I think
> 'Página de inicio de Firefox' should be http://start.mozilla.org/firefox. You
> don't seem to have 'Firefox Central' that the English one
>
(http://lxr.mozilla.org/aviarybranch/source/browser/locales/en-US/profile/bookmarks.html)
> has under 'Firefox and Mozilla Links', if you add it it should point to
> http://www.mozilla-europe.org/es/products/firefox/start/central.html.

I have corrected both links and added the missing one. Besides, I must mention
that the "Latest Headlines" in the default en-US bookmarks
(http://fxfeeds.mozillazine.org/rss20.xml) doesn't work for me, neither I'm able
to add the RSS for MozillaZine available in Mozilla.or's main web page, so I
have replaced it with the latest news of Mozilla (http://www.mozilla.org/news.rdf).



        Attachment #166878 -
        Attachment is obsolete: true

    
    

    
  
(In reply to comment #17)
> I have corrected both links and added the missing one. Besides, I must mention
> that the "Latest Headlines" in the default en-US bookmarks
> (http://fxfeeds.mozillazine.org/rss20.xml) doesn't work for me, neither I'm able
> to add the RSS for MozillaZine available in Mozilla.or's main web page, so I
> have replaced it with the latest news of Mozilla
(http://www.mozilla.org/news.rdf).

"Latest Headlines" in the default en-US bookmarks on the branch points to
fxfeeds.mozilla.org as in mozilla.org, not mozillazine.org.
http://fxfeeds.mozilla.org/rss20.xml works fine here.

    
    

    
  
(In reply to comment #19)
> 
> "Latest Headlines" in the default en-US bookmarks on the branch points to
> fxfeeds.mozilla.org as in mozilla.org, not mozillazine.org.
> http://fxfeeds.mozilla.org/rss20.xml works fine here.


Confirmed (although I'd swear first time I tried used that URL, without the file
name, and it didn't work.)

From what I can see, the feed uses BBC news service. There is no equivalent
service in the spanish public television/radio channel, and BBC in spanish
doesn't provide RSS feeds (at least, I haven't found it), so I used the first
one that appeared in Google and worked properly (Dirson which, by the way, has a
banner promoting Firefox in its main page).



    
    

    
  


  

        Attachment #167181 -
        Attachment is obsolete: true

    
    

    
  
Err... who is waiting for whom? Is Ebron waiting for Oscar to say something
about the latest attachment? Or is Ebron waiting for me to do something more
that I've forgotten? Are we waiting for Ebron or anyone else?

I know Oscar is not waiting for me, because we met last Sunday and we checked
the status of this bug. :-)

I understand that all of us are busy people and we can't always be ready to do
things in a snap. I just want to make sure that nobody is waiting for Oscar or
me to do something (and, if that's the case, to know what are we supposed to do).

    
    

    
  
Ricardo, I'll repeat what I said before: you need to set the approval-aviary
flag on the patch to get approval. :-)
Flags: blocking-aviary1.0?

    
    

    
  
Ok, I guess I set the right flag to ask for approval, although it is very
unclear why blocking-aviary should be selected if blocking aviary-L10N is
already selected and more generally what the flags are for since there is no
documentation whatsoever about the meaning of aviary related flags in bugzilla,
or if there is, it definitely means that it is damn hidden ! I also spent half
an hour searching mozilla.org for a document explaining how oscar and ricardo
should have set flags without any success. Could somebody point me to the
document explaining this process for localizers? Thanks

    
    

    
  
Comment on attachment 167215 [details]
Revised (v2) fully translated proposed bookmarks.html

I don't think I can be any clearer than 'set the approval-aviary
flag on the patch'.

        Attachment #167215 -
        Flags: approval-aviary?
Flags: blocking-aviary1.0?

    
    

    
  
Ok, now that you have set the flag yourself I see where it is located ! I guess
it is obvious for people who check patches everyday but it was clearly far from
easy to locate for people who never post patches to bugzilla !!! Confusing
bugzilla :( ...

As for the newsgroup message, how would a new localizer know about it?

    
    

    
  
(In reply to comment #23)
> Ricardo, I'll repeat what I said before: you need to set the approval-aviary
> flag on the patch to get approval. :-)


Sorry, I thought you were talking to Oscar, not me, since he is the one having
assigned the bug. Anyway, I couldn't agree more with Pascal's comments; I
understand it's needed to relieve reviewers from the burden of checking the
status of so many bugs, but it is not an intuitive process at all.


    
    

    
  
Comment on attachment 167215 [details]
Revised (v2) fully translated proposed bookmarks.html

the MozillaES link should be in the "Enlaces Firefox y Mozilla" folder, and no
trailing separator. There is no separator after the quick searches in the en-US
original either.

The structure of
http://lxr.mozilla.org/aviarybranch/source/browser/locales/en-US/profile/bookma
rks.html
is the measure. I won't decide if this blocks.

    
    

    
  


  
Bookmark file including Pike's comments, since I am not assigned to this bug, I
dont obsolete the previous patch. Oscar, Ricardo ? Can we check this patch in
and finally give full approval to the Spanish build

        Attachment #167942 -
        Attachment is obsolete: true

    
    

    
  
Please proceed and commit it. I hope this is the last obstacle for, at last, we
can see an es-ES firefox release published in mozilla.org.

        Attachment #167215 -
        Attachment is obsolete: true

    
    

    
  
Comment on attachment 167943 [details]
bookmarks file inluding pike's comments

asking for aviary approval

        Attachment #167943 -
        Flags: approval-aviary?

    
    

    
  
If this patch is approved, the only remaining issue will be bug 272992

Pike indicated which line should be changed

Oscar, can you provide a patch for that?

    
  

        Attachment #167943 -
        Flags: approval-aviary? → approval-aviary+

        Attachment #167215 -
        Flags: approval-aviary?

    
    

    
  
This bug should already be closed, as localized es-ES version of Firefox has
been released.

    
    

    
  
Though the bug is assigned to me against my will, I don't know what's on staff
minds, so don't expect me to close the bug, but the reporter.

    
    

    
  
Did the patch actually land? Whoever commits the patch is supposed to mark the
bug fixed.

    
    

    
  
The patch has approval+ but AFAIK, it hasn't landed. Will marking this bug fixed
make this patch land and official es-ES builds automatically compiled? Since I
wrote the patch I can mark the bug fixed, but don't ask me more, I am no
programmer and have no rights on your CVS.

    
    

    
  
Commited on CVS

    
  
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED

    
  
Flags: blocking-aviary1.0-L10N?

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: