268998 - Slovak (sk-SK) Firefox localization

Status: VERIFIED FIXED

(Mozilla Localizations :: Other, defect)

Description

[Pavel Franc - Mozilla.cz]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; cs-CZ; rv:1.7.5) Gecko/20041108 Firefox/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; cs-CZ; rv:1.7.5) Gecko/20041108 Firefox/1.0

Please check and import the following files into CVS.

Reproducible: Always
Steps to Reproduce:

Comment 1

[Pavel Franc - Mozilla.cz]

Attachment: Browser files

Files have windows endnings.

Comment 2

[Pavel Franc - Mozilla.cz]

Attachment: Toolkit files

Files have windows endings

Comment 3

[Pavel Franc - Mozilla.cz]

The files will be manged by Peter as soon as bug 268087 get fixed.

Comment 4

[Zibi Braniecki [:zbraniecki][:gandalf]]

Short review.
Issues:

1) mozilla/browser/defines.inc - UUID taken from en-US. Please, select yours
2) all line endings are in Windows style. I'm not sure if there's a rule, but
everywhere else in CVS we use Unix one.
3) in searchplugins there is "creativecommons" - i don't know if you got
acceptation on this.
4) 

Entities in ./chrome/global/finddialog.dtd don't match:
    cancelButton.label

Properties in ./chrome/mozapps/downloads/downloads.properties don't match:
    statusFormat

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

ok. i have confirmation from Benjamin. There should be only unix style line
endings. Please fix it

Comment 6

[Zibi Braniecki [:zbraniecki][:gandalf]]

please, forget point 4. It's my mistake.

Comment 7

[Pavel Franc - Mozilla.cz]

Attachment: sk-SK files

(In reply to comment #4)
> 1) mozilla/browser/defines.inc - UUID taken from en-US. Please, select yours
Fixed by generating new UUID by uuidgen.

> 2) all line endings are in Windows style. I'm not sure if there's a rule, but

> everywhere else in CVS we use Unix one.
Fixed by 'find -type f | xargs dos2unix -U'

> 3) in searchplugins there is "creativecommons" - i don't know if you got
> acceptation on this.
It was copied from en-US. Removed.

> 4) 
Not issues as discussed over IRC.

Comment 8

[Pavel Franc - Mozilla.cz]

Attachment: sk-SK files

Now with changed endins only for text files.
find | xargs file | grep "":.*text" | cut -f1 -d: | xargs dos2unix -U

Comment 9

[Zibi Braniecki [:zbraniecki][:gandalf]]

Seems to be OK for me. comparelocales returns positive, my eye too.

Comment 10

[Benjamin Smedberg]

Checked in on branch.

Comment 11

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Should it be added to all-locales so we start doing builds for it, or is it not
ready for that?

Also, if we're likely to ship Firefox 1.0 sk-SK at some point, it should be
added to the table in the webtree in mozilla-org/html/download.js with
"official: false" (until it's actually shipped, at which point the false becomes
true).  This makes it appear as "Not Yet Available" in
http://www.mozilla.org/products/firefox/all.html .

Comment 12

[Pavel Franc - Mozilla.cz]

(In reply to comment #11)
> Should it be added to all-locales so we start doing builds for it, or is it not
> ready for that?

Please add the sk-SK l10n into the building process.