269632 - Add paint flashing for OS/2

Status: RESOLVED FIXED

(Core Graveyard :: GFX: OS/2, defect)

Description

[Dainis Jonitis]

Comment 1

[Dainis Jonitis]

Attachment: diff -d -u -8

Comment 2

[Dainis Jonitis]

In bug 268090 Boris Zbarsky recommends to use paint flashing to investigate OS/2
problem. Here is the widget code to implement this for OS/2.

Enable it under Edit-Preferences-Debug-Events-Paint flashing

Comment 3

[Dainis Jonitis]

Comment on attachment 165792 [details] [diff] [review]
diff -d -u -8

This is just a port from Win32 nsWindow.cpp

Comment 4

[Peter Weilbacher]

Great, thanks. Flashes nicely for me.

Comment 5

[Mike Kaply [:mkaply]]

Comment on attachment 165792 [details] [diff] [review]
diff -d -u -8

Why is the change to eventStatus necessary?

Comment 6

[Dainis Jonitis]

Comment for Win32 nsWindow says that eventStatus != nsEventStatus_eIgnore is
just an optimization to skip flashing those invalidations that are not handled
by DispatchWindowEvent and thus will not be repainted by Mozilla.
I thought it is good to keep both win32 and os/2 implementations as close as
possible.

Comment 7

[Mike Kaply [:mkaply]]

Comment on attachment 165792 [details] [diff] [review]
diff -d -u -8

a=mkaply for 1.85

Comment 8

[Mike Kaply [:mkaply]]

Fix checked into trunk.