269888 - Search ignoring Glossary

Status: RESOLVED FIXED

(SeaMonkey :: Help Viewer, defect)

Description

[Leung Wing Chung]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0

mozilla/toolkit/components/help/content/help.js 
627     // search glossary.
628     tree = helpSearchPanel;

Corrected code:
627     // search glossary.
628     tree = helpGlossaryPanel;

Reproducible: Always
Steps to Reproduce:

Comment 1

[Leung Wing Chung]

Attachment: Patch of mozilla/toolkit/components/help/content/help.js

Comment 2

[Steffen Wilberg]

Thanks for discovering this bug.
Please create patches like this:
cvs diff -up8 mozilla/toolkit/components/help/content/help.js.

Comment 3

[R.J. Keller]

--> lwchk2001

patch looks good, but do a "cvs diff -u -w > new.diff" for patches please :).

btw steffen, I'd recommend doing -w to ignore whitespace changes. Helps a lot
with some text editors.

Comment 4

[Steffen Wilberg]

-w is nice if you don't want to change the whitespace. But I expect our
contributors not to use Notepad ;-)

I recommend -p for c++ and js code. That displays the name of the function in
the line containing the line numbers.

And -8 (or any number) is for 8 lines of context.

Comment 5

[R.J. Keller]

(In reply to comment #4)
> -w is nice if you don't want to change the whitespace. But I expect our
> contributors not to use Notepad ;-)

I usually need -w for Textpad and Kate. I have actually yet encountered a
texteditor (other than stupid DOS Edit :)) that doesn't need -w. Just thought
I'd suggest since I spent about 6 months trying to figure out a way to get
around it :). Of course I don't use any of those weird linux text editors that
might not do those whitespace changes.

Comment 6

[Leung Wing Chung]

I actually do not have access to Mozilla by cvs, and the diff is created by some
jEdit plugin... :-( I guess I'll try later.

I use Scite and jEdit... both take care of tab and CR/LF, so I don't think I
need a -w.

BTW, are you waiting for my patch?

Comment 7

[Leung Wing Chung]

Attachment: Patch of mozilla/toolkit/components/help/content/help.js

Comment 8

[Leung Wing Chung]

Finally grabbed the command line version of the CVS... it seems not difficult to
use. But I HATE the CR/LF conversion feature. How can I avoid the bad LF to
CR/LF conversion?

Comment 9

[Steffen Wilberg]

Thanks for making the patch. We're not exactly in a hurry here, since the trunk
merge is about to happen, which might simply overwrite code in the trunk.

Are you using Windows, with cygwin? There's an installation option where you can
choose between dos and unix style lineendings. You should chosse unix style there.

Comment 10

[R.J. Keller]

(In reply to comment #9)
> Thanks for making the patch. We're not exactly in a hurry here, since the trunk
> merge is about to happen, which might simply overwrite code in the trunk.
> 
> Are you using Windows, with cygwin? There's an installation option where you can
> choose between dos and unix style lineendings. You should chosse unix style there.

I get this problem on linux too. It has nothing to do with the line endings. It
just likes extra whitespace :).

I would think that his patch will still apply using his style, so we might be OK.

Comment 11

[Leung Wing Chung]

I don't think I have problems dealing w/ whitespaces though... because I trained
myself to treat tab and space differently. Personally, I don't allow any extra
whitespace for word processing. Of course, I don't use any editor w/o display
tabs/spaces function. (In other words, I treat a text file as a binary file.)

Comment 12

[R.J. Keller]

Comment on attachment 167086 [details] [diff] [review]
Patch of mozilla/toolkit/components/help/content/help.js

We really should be searching the glossary. r=[e-mail].

Comment 13

[R.J. Keller]

Fix checked in.