Add versions of nsDependentString and friends to the Gecko SDK

RESOLVED FIXED in mozilla1.8beta1

Status

()

Core
String
--
enhancement
RESOLVED FIXED
13 years ago
13 years ago

People

(Reporter: Darin Fisher, Assigned: Darin Fisher)

Tracking

(Blocks: 1 bug)

Trunk
mozilla1.8beta1
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

79.91 KB, patch
Benjamin Smedberg
: review+
Details | Diff | Splinter Review
(Assignee)

Description

13 years ago
Add versions of nsDependentString and friends to the Gecko SDK.

This is possible with the advent of NS_StringContainerInit2 from bug 264274.
(Assignee)

Updated

13 years ago
Blocks: 268520
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.8beta
(Assignee)

Updated

13 years ago
Depends on: 264274
(Assignee)

Updated

13 years ago
Blocks: 205425
(Assignee)

Comment 1

13 years ago
Created attachment 166130 [details] [diff] [review]
v0 preliminary patch

This is just a preliminary patch.  At the minimum, I think it is important to
use some preprocessor magic to rename classnames either internally or
externally so that there are not symbol conflicts at runtime.
(Assignee)

Comment 2

13 years ago
Created attachment 167276 [details] [diff] [review]
v1 patch
(Assignee)

Updated

13 years ago
Attachment #166130 - Attachment is obsolete: true
(Assignee)

Updated

13 years ago
Attachment #167276 - Flags: review?(bsmedberg)

Comment 3

13 years ago
Comment on attachment 167276 [details] [diff] [review]
v1 patch

I'm confused. How did you solve the "conflicting nsAString symbols" problem? It
seems that you're mixing the frozen and non-frozen string impls; am I wrong
about that?
(Assignee)

Comment 4

13 years ago
> I'm confused. How did you solve the "conflicting nsAString symbols" problem?

I didn't change nsAString.  We still have the problem of the internal nsAString
being named the same as the external one.  That needs to be solved by
introducing a #define for nsAString, either internally or externally.  That
isn't a prerequisite for this patch.


> It seems that you're mixing the frozen and non-frozen string impls; am I 
> wrong about that?

I am not mixing the two.  Instead, I am making available many of the string
classes, like nsDependentString and nsDependentSubstring, but I am expressing
them in terms of the frozen string library.  This does not eliminate the
internal string classes; it only provides similar idioms for those writing code
on top of the Gecko SDK.  Take note of the #ifdef MOZILLA_STRICT_API :-)

Comment 5

13 years ago
Comment on attachment 167276 [details] [diff] [review]
v1 patch

ok, I was confusing nsStringSupport.h and nsStringAPI.h
Attachment #167276 - Flags: review?(bsmedberg) → review+
(Assignee)

Comment 6

13 years ago
fixed-on-trunk
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.