Closed Bug 270235 Opened 21 years ago Closed 18 years ago

printUtils.js assumes everything is either thunderbird or firefox

Categories

(Toolkit :: Printing, defect)

Product:
Toolkit
Component:
Printing
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: mvl, Unassigned)

References

Details

(Whiteboard: [xulrunner bad dependency])

http://lxr.mozilla.org/seamonkey/source/toolkit/components/printing/content/printUtils.js#235 That first #ifdefs thunderbird, and if you are not thunderbird, it does browser stuff. sunbird isn't thunderbird, and also is no browser. So this fails.
Blocks: 270245
Assignee: firefox → nobody
Component: General → Preferences
Product: Firefox → Toolkit
QA Contact: firefox.general → nobody
Version: Trunk → unspecified
Wouldn't a simple #ifndef MOZ_PHOENIX instead of #ifdef MOZ_THUNDERBIRD solve this?
No. That's just as bad, as it means that there still isn't a single toolkit for all apps.
Whiteboard: [xulrunner bad dependency]
Should be fixed by Bug 321954
Component: Preferences → Printing
Depends on: 321954
QA Contact: nobody → printing
Indeed.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.