270243 - embed prompter mangles non-ascii input

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: GTK Widget, defect)

Description

[Christian Persch (GNOME) (away; not receiving bug mail)]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20041020 Galeon/1.3.18.99
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8a5) Gecko/20041113 Epiphany/1.5.0

The gtk+ native prompt implementation mangles non-ascii input; it shows up as if
it was interpreted as iso-8859-1.

Reproducible: Always
Steps to Reproduce:
1. Load the attached testcase in TestGtkEmbed or Epiphany or Galeon
2. Click on the "Click here for prompt" text
3. Enter "äöüß" in the input prompt, then OK.

Actual Results:  
The text field shows "äöüÃ".

Expected Results:  
The text field shows "äöüß".

Does work as expected in mozilla-the-browser (same build date).

Comment 1

[Christian Persch (GNOME) (away; not receiving bug mail)]

Attachment: testcase

Comment 2

[Christian Persch (GNOME) (away; not receiving bug mail)]

Attachment: proposed fix

ToNewUnicode is lossy.

Comment 3

[Christian Persch (GNOME) (away; not receiving bug mail)]

Comment on attachment 166155 [details] [diff] [review]
proposed fix

darin: Marco suggested I ask you for sr to make sure we have the string usage
right.

Comment 4

[Reinout van Schouwen]

confirmed.

Comment 5

[Christian Persch (GNOME) (away; not receiving bug mail)]

Comment on attachment 166155 [details] [diff] [review]
proposed fix

I think we should have this on 1.7 branch too. It's a straigh-forward fix for
an i18n bug.

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in embedding/browser/gtk/src/EmbedPrompter.cpp;
/cvsroot/mozilla/embedding/browser/gtk/src/EmbedPrompter.cpp,v  <-- 
EmbedPrompter.cpp
new revision: 1.14; previous revision: 1.13
done

Comment 7

[Mike Kaply [:mkaply]]

Comment on attachment 166155 [details] [diff] [review]
proposed fix

a=mkaply for 1.7.6

Comment 8

[Asa Dotzler [:asa]]

Comment on attachment 166155 [details] [diff] [review]
proposed fix

a=asa for branches checkin.

Comment 9

[Marco Pesenti Gritti]

Checked in on aviary1.0.1

Checking in EmbedPrompter.cpp;
/cvsroot/mozilla/embedding/browser/gtk/src/EmbedPrompter.cpp,v  <-- 
EmbedPrompter.cpp
new revision: 1.12.24.1; previous revision: 1.12
done

Comment 10

[Marco Pesenti Gritti]

Checked in on mozilla 1.7.6 branch

Checking in EmbedPrompter.cpp;
/cvsroot/mozilla/embedding/browser/gtk/src/EmbedPrompter.cpp,v  <-- 
EmbedPrompter.cpp
new revision: 1.12.2.1; previous revision: 1.12
done