bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

embed prompter mangles non-ascii input

RESOLVED FIXED

Status

Core Graveyard
Embedding: GTK Widget
RESOLVED FIXED
14 years ago
6 years ago

People

(Reporter: Christian Persch (GNOME) (away; not receiving bug mail), Assigned: Christian Persch (GNOME) (away; not receiving bug mail))

Tracking

({fixed-aviary1.0.1, fixed1.7.6})

Trunk
x86
Linux
fixed-aviary1.0.1, fixed1.7.6

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20041020 Galeon/1.3.18.99
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8a5) Gecko/20041113 Epiphany/1.5.0

The gtk+ native prompt implementation mangles non-ascii input; it shows up as if
it was interpreted as iso-8859-1.

Reproducible: Always
Steps to Reproduce:
1. Load the attached testcase in TestGtkEmbed or Epiphany or Galeon
2. Click on the "Click here for prompt" text
3. Enter "äöüß" in the input prompt, then OK.

Actual Results:  
The text field shows "äöüß".

Expected Results:  
The text field shows "äöüß".

Does work as expected in mozilla-the-browser (same build date).
Created attachment 166155 [details] [diff] [review]
proposed fix

ToNewUnicode is lossy.
Attachment #166155 - Flags: review?(marco)

Updated

14 years ago
Attachment #166155 - Flags: review?(marco) → review+
Comment on attachment 166155 [details] [diff] [review]
proposed fix

darin: Marco suggested I ask you for sr to make sure we have the string usage
right.
Attachment #166155 - Flags: superreview?(darin)

Comment 4

14 years ago
confirmed.
Status: UNCONFIRMED → NEW
Ever confirmed: true

Updated

14 years ago
Attachment #166155 - Flags: superreview?(darin) → superreview+
Comment on attachment 166155 [details] [diff] [review]
proposed fix

I think we should have this on 1.7 branch too. It's a straigh-forward fix for
an i18n bug.
Attachment #166155 - Flags: approval1.7.6?
Checking in embedding/browser/gtk/src/EmbedPrompter.cpp;
/cvsroot/mozilla/embedding/browser/gtk/src/EmbedPrompter.cpp,v  <-- 
EmbedPrompter.cpp
new revision: 1.14; previous revision: 1.13
done
Assignee: blizzard → chpe
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED

Comment 7

14 years ago
Comment on attachment 166155 [details] [diff] [review]
proposed fix

a=mkaply for 1.7.6
Attachment #166155 - Flags: approval1.7.6? → approval1.7.6+

Updated

14 years ago
Attachment #166155 - Flags: approval-aviary1.0.1?

Comment 8

14 years ago
Comment on attachment 166155 [details] [diff] [review]
proposed fix

a=asa for branches checkin.
Attachment #166155 - Flags: approval-aviary1.0.1? → approval-aviary1.0.1+

Comment 9

14 years ago
Checked in on aviary1.0.1

Checking in EmbedPrompter.cpp;
/cvsroot/mozilla/embedding/browser/gtk/src/EmbedPrompter.cpp,v  <-- 
EmbedPrompter.cpp
new revision: 1.12.24.1; previous revision: 1.12
done

Comment 10

14 years ago
Checked in on mozilla 1.7.6 branch

Checking in EmbedPrompter.cpp;
/cvsroot/mozilla/embedding/browser/gtk/src/EmbedPrompter.cpp,v  <-- 
EmbedPrompter.cpp
new revision: 1.12.2.1; previous revision: 1.12
done
Keywords: fixed-aviary1.0.1, fixed1.7.6
Component: Embedding: GTK Widget → Embedding: GTK Widget
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.