270580 - Cannot print if first printing trigger is javascript(window.print()) with a printer with non-Latin1 (e.g. Japanese) characters in its name

Status: RESOLVED FIXED

(Core :: Printing: Output, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a5) Gecko/20041117
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a5) Gecko/20041117

On Win9x, if first printing is called by javascript(window.print()),
common dialog cannot find the default printer.
But if the printer name is made by only latain1, this problem is not reproduced.

Reproducible: Always
Steps to Reproduce:
1. Include non-Latain1 character into default printer name.
2. Start the Mozilla.
3. Click the URL of this bug.

Actual Results:  
Printer is not found.

Expected Results:  
Common dialog is shown.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

If Bug 270812 is fixed, this problem will not be reproduced.
But not fixed...

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch rv1.0

O.K. This patch will fix this bug!

Comment 3

[Jungshik Shin]

Comment on attachment 166548 [details] [diff] [review]
Patch rv1.0

>? gfx/src/windows/dependentLibs.h
>? gfx/src/windows/gkgfxwin.pdb
>Index: gfx/src/windows/nsDeviceContextSpecWin.cpp
>===================================================================

>+    nsCAutoString newNameNative(name);
>+    nsAutoString newName;
>+    NS_CopyNativeToUnicode(newNameNative, newName);

You can just do this:

nsAutoString newName;
NS_CopyNativeToUnicode(nsDependentCString(name), newName);

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch rv1.1

Comment 5

[Jungshik Shin]

Comment on attachment 166645 [details] [diff] [review]
Patch rv1.1

>     nsString newName; 
>-    newName.AssignWithConversion(name);
>+    NS_CopyNativeToUnicode(nsDependentCString(name), newName);

Gee, why did you go back to |nsString newName|? |nsAutoString newName| is
better than |nsString newName| because |newName| is shorter than 64 characters
in most cases. See http://www.mozilla.org/projects/xpcom/string-guide.html

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch rv1.2

Comment 7

[Jungshik Shin]

Comment on attachment 166672 [details] [diff] [review]
Patch rv1.2

r=jshin

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 166672 [details] [diff] [review]
Patch rv1.2

sr=bzbarsky

Comment 9

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 166672 [details] [diff] [review]
Patch rv1.2

The risk of this patch is low.

Comment 10

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Jungshik:

Please check-in to Trunk.

Comment 11

[Asa Dotzler [:asa]]

Comment on attachment 166672 [details] [diff] [review]
Patch rv1.2

1.0 has shipped and we're looking to the trunk for future Firefox releases.

Comment 12

[Asa Dotzler [:asa]]

Comment on attachment 166672 [details] [diff] [review]
Patch rv1.2

1.7.5 has shipped. Moving request to 1.7.6.

Comment 13

[Asa Dotzler [:asa]]

1.7.5 has shipped. Moving request to 1.7.6.

Comment 14

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Jungshik:

Please check-in the patch to Trunk.

Comment 15

[Jungshik Shin]

sorry for the delay. fix checked in

Comment 16

[Daniel Veditz [:dveditz]]

not blocking 1.7.6 but we'd take the patch if in quickly. add fixed1.7.6 keyword
when checked-in.

Comment 17

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 166672 [details] [diff] [review]
Patch rv1.2

a=caillon (on behalf of drivers) for 1.7.6.  Please land this quickly.