270798 - ASSERTION: getElementById(""), fix caller?: '!aId.IsEmpty()' @onLocationFound

Status: RESOLVED FIXED

(Other Applications Graveyard :: Venkman JS Debugger, defect)

Description

[timeless]

###!!! ASSERTION: getElementById(""), fix caller?: '!aId.IsEmpty()', file
r:/mozilla/content/xul/document/src/nsXULDocument.cpp, line 1732
Break: at file r:/mozilla/content/xul/document/src/nsXULDocument.cpp, line 1732
0 [native frame]
1 onLocationFound(window = [object ChromeWindow @ 0x2fd7f28], container =
[object XULElement @ 0x385
ec50]) ["chrome://venkman/content/view-manager.js":873]
    content = [object XULElement @ 0x3452798]
    beforeNode = undefined
    gutterContainer = undefined
    this = [object ChromeWindow @ 0x2fd7f28]
2 onWindowLoaded(window = [object ChromeWindow @ 0x2fd7f28])
["chrome://venkman/content/view-manager
.js":660]
    container = [object XULElement @ 0x385ec50]
    this = [object ChromeWindow @ 0x2fd7f28]
3 vmgr_ensurelocation(cb = [function], parsedLocation = [object Object])
["chrome://venkman/content/
view-manager.js":672]
    viewManager = [object Object]
    onWindowLoaded = [function]
    window = [object ChromeWindow @ 0x2fd7f28]
    this = [object Object]
4 vmgr_move(height = undefined, width = undefined, parsedLocation = [object
Object], viewId = "sessi
on") ["chrome://venkman/content/view-manager.js":961]
    viewManager = [object Object]
    moveContent = [function]
    onLocationFound = [function]
    view = [object Object]
    currentContent = [object XULElement @ 0x3452798]
    this = [object Object]
5 vmgr_dewdropinn(sourceView = [object Object], targetView = [object Object],
direction = "right") [
"chrome://venkman/content/view-manager.js":1636]
    reparent = [function]
    destContainer = [object XULElement @ 0x385ec50]
    destBefore = undefined
    currentContent = [object XULElement @ 0x34ec8e8]
    currentContainer = [object XULElement @ 0x33dec28]
    parentType = "vertical"
    dest = [object Object]
    parsedTarget = x-vloc:/mainwindow/gutter?target=view&id=windows&before=source2
    viewManager = [object Object]
    this = [object Object]
6 callProcessDrop(116) ["chrome://venkman/content/view-manager.js":1469]
    this = [object ChromeWindow @ 0x2fd7f28]
7 [native frame]

my guess is that
1635     dest.before = destBefore ? destBefore.getAttribute("id") : null;
took the ? path on a id-less node

Comment 1

[timeless]

Attachment: try to honor api

clearly had i read the stack, i'd have realized that my guess was wrong...

Comment 2

[James Ross]

Comment on attachment 211409 [details] [diff] [review]
try to honor api

>-    dest.before = destBefore ? destBefore.getAttribute("id") : null;
>+    var before = destBefore ? destBefore.getAttribute("id")) : null;
>+    if (before)
>+        dest.before = before;

You've got a spare bracket in there.

You could more simply do:

+    if (destBefore)
+        dest.before = destBefore.getAttribute("id");

Unless you know of a case where destBefore exists but has no ID? (I don't think it would make any sense if that occured.)

r=silver with either way (with the extra bracket removed)

Comment 3

[timeless]

Comment on attachment 211409 [details] [diff] [review]
try to honor api

mozilla/extensions/venkman/resources/content/view-manager.js 	1.13

i went w/ silver's style