271621 - Dark line at top of status bar doesn't show.

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Jasper]

Some where in the swicth from Jaguar to Panther Camino stoped showing the dark
line at the top of the status bar. But more recent users are also saying it
doesn't show anymore on 10.2.8.

Following are some ideas from a non coder:
- it might be that Apple made a change somewhere that caused the line to not be
painted for a mysterious reason.
- The status bar isn't a custom view as I would have expected, but is just a
regular ns view in the nib that is dynamically ofset. Maybe that's why a line is
not shown?
- when using a custom view you need to put some code to make sure a border is
painted. This is done for the bookmark toolbar in BookmarkToolbar.mm line
327-336 for the bottom border.
- I had a look to BrowserWindowController.mm to see if there was anything writen
there that would suggest that we want to draw a border but I couldn't find
anything like I did find in the bookmark bar code.

It would be very nice if we could get back the line, I know it's a detail but
right now it looks a bit funky.

Comment 1

[Geoff "temporarily off bugmail" Beier]

I think the new tabs did this... honestly, it's no mystery to me why it's not
there. I'm not sure how it was getting there before though :-)

Taking.

Comment 2

[Geoff "temporarily off bugmail" Beier]

Attachment: adds the dark line to the top of the status bar

A trivial NSView subclass takes care of the problem.

To apply the patch:

1. rm -rf camino/build/Camino.app
2. Copy the .nib into your tree and touch it.
3. Add the new class to the xcode project.

Comment 3

[Mike Pinkerton (not reading bugmail)]

but this also happens on 082

Comment 4

[Jasper]

Yes it happens in all version of Camino on Panther, and from what I heard also
in 10.2 but I can't check.

Comment 5

[Mike Pinkerton (not reading bugmail)]

line draws fine on 10.2 (in 082 candidates). we only need this for panther.

Comment 6

[Geoff "temporarily off bugmail" Beier]

Comment on attachment 166997 [details]
adds the dark line to the top of the status bar

yuck. there's a gap between the scrollbar and the line. don't bother reviewing
this.

Comment 7

[Josh Aas]

this is a minor bug, not an enhancement as far as I can tell

Comment 8

[Josh Aas]

Attachment: stab v1.0

I'm not requesting review on purpose because I haven't nicely packaged this fix
and I'm not sure I want the code in separate files. Anyway, just make the
status bar NSView an instance of the subclass I wrote and the black line should
appear (add the new class files to Xcode, blah blah blah).

If Geoff likes this fix I'll package it up nicely and request review.

Comment 9

[Josh Aas]

Comment on attachment 176522 [details]
stab v1.0

I think "stab v1.0" is actually the right thing to do. We should probably have
the status bar draw its own separator if for no other reason than that it makes
hiding the status bar in the future easier.

Comment 10

[Simon Fraser [no longer active]]

For new files, 'cvs add' them (which is a local operation only), then cvs diff -N.

Comment 11

[Simon Fraser [no longer active]]

Comment on attachment 176522 [details]
stab v1.0

You need to specify a color.

Comment 12

[Josh Aas]

Comment on attachment 176522 [details]
stab v1.0

arg - cancelled the wrong review

Comment 13

[Mike Pinkerton (not reading bugmail)]

i landed a rewrite of what josh was doing as part of 1.0 (it needed work). it
needs testing on 10.2 before i mark it fixed, ill try it on my 10.2 box on
monday and then mark it so then.

Comment 14

[Jasper]

Yeeeehaa, Mike finally nailed this prehistoric anoying my ass off bug. Thank you
so much. Hey and it even works on 10.2 :)