271774 - Firefox Page Setup's "Shrink to fit page width" preference is not saved across sessions

Status: RESOLVED FIXED

(Toolkit :: Printing, defect)

Description

[shadytrees]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041103 Firefox/1.0RC2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041103 Firefox/1.0RC2

There was a bug for this for Mozilla (Bug 147384), which covered all Page Setup
settings. Indeed, Mozilla remembers the checkbox "Shrink to fit page width"
across sessions whereas Firefox does not. The closest related bug I found to
this was Bug 255346, which dealt with scale percentages. I'm assuming that this
preference should be saved across sessions, seeing the other Page Setup
preference remembering bugs.

Aside: Mozilla has a "print.printer_name.print_shrink_to_fit" preference that is
written to when the checkbox is changed. Firefox doesn't.

Reproducible: Always
Steps to Reproduce:
1. File -> Page Setup... -> Uncheck "Shrink to page width" -> OK
2. Restart Firefox. File -> Page Setup...
Actual Results:  
"Shrink to page width" is checked.

Expected Results:  
"Shrink to page width" should be unchecked.

Comment 1

[Steffen Wilberg]

I can reproduce this with Firefox 1.0 on Linux as well.
-> Toolkit, printing, and confirming.

Comment 2

[Ganesh]

Attachment: patch for this bug

I am attaching a patch for this. Can someone verify this please?

Comment 3

[Mike Connor [:mconnor]]

Comment on attachment 167085 [details] [diff] [review]
patch for this bug

r=me for the printPageSetup.js part of the patch, the first bit was relanded by
IanN about a week ago.

one nit, please leave the blank line in place, just add the lines in question.

Comment 4

[Ganesh]

Attachment: patch based on review

Comment 5

[Steffen Wilberg]

Checking in mozilla/toolkit/components/printing/content/printPageSetup.js;
/cvsroot/mozilla/toolkit/components/printing/content/printPageSetup.js,v  <-- 
printPageSetup.js
new revision: 1.3; previous revision: 1.2
done

Comment 6

[Steffen Wilberg]

I guess I forgot to mark this as fixed after checking in.