271984 - Default milestone should be a <select>, not a text entry.

Status: RESOLVED FIXED

(Bugzilla :: Administration, task)

Description

[Christian Reis]

The product's default milestone is currently a text entry; this is unreasonable
given that milestones are a bound list specified per-product. Consensus on
developers@ is that it be moved to a <select> menu.

Comment 1

[Rémi Zara]

Attachment: make the default milestone a <select>

Comment 2

[Frédéric Buclin]

Comment on attachment 212355 [details] [diff] [review]
make the default milestone a <select>

>Index: template/en/default/admin/products/edit-common.html.tmpl

>+          <option [% "selected=\"selected\"" IF m.name == product.defaultmilestone %]>
>+            [%- m.name FILTER html -%]</option>

The <option> must have a 'value' attribute.

>+      [% ELSE %]
>+            <font color="red">missing</font>
>+      [% END %]

Nit: fix the indentation of <font> (2 whitespaces for templates).

Comment 3

[Rémi Zara]

Attachment: patch v1.1

Addressed comments

Comment 4

[Frédéric Buclin]

Comment on attachment 212356 [details] [diff] [review]
patch v1.1

>+      [% IF product.milestones.size %]
>+        <select name="defaultmilestone">
>+        [% FOREACH m = product.milestones %]

Nit: [% FOREACH %] should not be aligned with <select> (indentation).


>+      [% ELSE %]
>+        <font color="red">missing</font>
>+      [% END %]

When adding a new product, I can no longer set the default milestone. In this case, you should offer a text box (as it does actually) instead of displaying this message.

Comment 5

[Frédéric Buclin]

bkor, I'm reassigning the bug to remi as he is working on it (he is a newbie, and thought the bug was assigned to the default assignee because its status was NEW instead of ASSIGNED).

Comment 6

[Rémi Zara]

Attachment: patch v1.2

Addressed comments.

It is strange though that you can choose a not yet existant milestone as the default. I guess that the fact that there was no foreign keys in MySQL helps :)

Comment 7

[Frédéric Buclin]

(In reply to comment #6)
> It is strange though that you can choose a not yet existant milestone as the
> default. I guess that the fact that there was no foreign keys in MySQL helps

The reason you can choose a milestone when creating a new product is that this milestone will be added to the miletones table as well, so there is no referential integrity problem. But as soon as the product is created, it doesn't let you create new milestones from here anymore and you have to go to editmilestones.cgi to add new ones.

Comment 8

[Frédéric Buclin]

Comment on attachment 212357 [details] [diff] [review]
patch v1.2

Works great! Thanks for the patch. r=LpSolit

Comment 9

[Frédéric Buclin]

Checking in template/en/default/admin/products/edit-common.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/products/edit-common.html.tmpl,v  <--  edit-common.html.tmpl
new revision: 1.5; previous revision: 1.4
done