272130 - TBTrunk crash in [@ nsMsgContentPolicy::ShouldLoad]

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[David :Bienvenu]

I accidentally deleted an rss feed, moved it out of the trash, and then read a
message in the feed. I crashed in nsMsgContentPolicy::ShouldLoad - fix upcoming.

Comment 1

[David :Bienvenu]

Attachment: proposed fix

the folder was coming back null - GetFolder should probably return an error if
there's no folder, but this fix is a lot safer for right now.

Comment 2

[Jay Patel [:jay]]

Reopening to see that we get this patched up on the Trunk.  It has become a
major topcrash with recent ThunderbirdTrunk builds.

Here is a recent incident:
Incident ID: 3532525
Stack Signature	nsMsgContentPolicy::ShouldLoad 5f9a761c
Product ID	ThunderbirdTrunk
Build ID	2005020506
Trigger Time	2005-02-06 13:07:36.0
Platform	Win32
Operating System	Windows NT 5.1 build 2600
Module	THUNDE~1.EXE + (0044a4b2)
URL visited	
User Comments	trying to open a saved draft email which was created while offline
Since Last Crash	8589 sec
Total Uptime	8589 sec
Trigger Reason	Access violation
Source File, Line No.
e:/builds/tinderbox/thunderbird-trunk/WINNT_5.0_Depend/mozilla/mailnews/base/src/nsMsgContentPolicy.cpp,
line 271
Stack Trace 	
nsMsgContentPolicy::ShouldLoad 
[e:/builds/tinderbox/thunderbird-trunk/WINNT_5.0_Depend/mozilla/mailnews/base/src/nsMsgContentPolicy.cpp,
line 271]
nsContentPolicy::CheckPolicy 
[e:/builds/tinderbox/thunderbird-trunk/WINNT_5.0_Depend/mozilla/content/base/src/nsContentPolicy.cpp,
line 219]
nsContentPolicy::ShouldLoad 
[e:/builds/tinderbox/thunderbird-trunk/WINNT_5.0_Depend/mozilla/content/base/src/nsContentPolicy.cpp,
line 282]
NS_CheckContentLoadPolicy 
[../../../dist/include/content/nsContentPolicyUtils.h, line 165]
nsContentUtils::CanLoadImage 
[e:/builds/tinderbox/thunderbird-trunk/WINNT_5.0_Depend/mozilla/content/base/src/nsContentUtils.cpp,
line 1845]
nsImageLoadingContent::ImageURIChanged 
[e:/builds/tinderbox/thunderbird-trunk/WINNT_5.0_Depend/mozilla/content/base/src/nsImageLoadingContent.cpp,
line 431]
nsImageLoadingContent::ImageURIChanged 
[e:/builds/tinderbox/thunderbird-trunk/WINNT_5.0_Depend/mozilla/content/base/src/nsImageLoadingContent.cpp,
line 390]
nsHTMLImageElement::SetParent 
[e:/builds/tinderbox/thunderbird-trunk/WINNT_5.0_Depend/mozilla/content/html/content/src/nsHTMLImageElement.cpp,
line 614]
nsGenericElement::AppendChildTo 
[e:/builds/tinderbox/thunderbird-trunk/WINNT_5.0_Depend/mozilla/content/base/src/nsGenericElement.cpp,
line 2602]
SinkContext::AddLeaf 
[e:/builds/tinderbox/thunderbird-trunk/WINNT_5.0_Depend/mozilla/content/html/document/src/nsHTMLContentSink.cpp,
line 1564]
HTMLContentSink::AddLeaf 
[e:/builds/tinderbox/thunderbird-trunk/WINNT_5.0_Depend/mozilla/content/html/document/src/nsHTMLContentSink.cpp,
line 3120]
CNavDTD::AddLeaf 
[e:/builds/tinderbox/thunderbird-trunk/WINNT_5.0_Depend/mozilla/parser/htmlparser/src/CNavDTD.cpp,
line 3570]
CNavDTD::HandleStartToken 
[e:/builds/tinderbox/thunderbird-trunk/WINNT_5.0_Depend/mozilla/parser/htmlparser/src/CNavDTD.cpp,
line 1643]
CNavDTD::HandleToken 
[e:/builds/tinderbox/thunderbird-trunk/WINNT_5.0_Depend/mozilla/parser/htmlparser/src/CNavDTD.cpp,
line 904]
CNavDTD::BuildModel 
[e:/builds/tinderbox/thunderbird-trunk/WINNT_5.0_Depend/mozilla/parser/htmlparser/src/CNavDTD.cpp,
line 461]
nsParser::BuildModel 
[e:/builds/tinderbox/thunderbird-trunk/WINNT_5.0_Depend/mozilla/parser/htmlparser/src/nsParser.cpp,
line 2047]

Comment 3

[Scott MacGregor]

Attachment: fix the new crash on the trunk

The trunk crash is different from the one originally reported in this bug.
Here's a null ptr check to address the new trunk crash.

Comment 4

[timeless]

Comment on attachment 174346 [details] [diff] [review]
fix the new crash on the trunk

i'm almost certain this is wrong. returning NS_OK for the false case does not
match the spirit of returning a failure code for a failure case. please justify
this

Comment 5

[Scott MacGregor]

fixed