272151 - reorganize files within layout

Status: RESOLVED FIXED

(Core :: Layout, defect, P1)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I posted a bunch of proposals for reorganizing files within layout a while ago
(see threads following as well):

http://groups.google.com/groups?selm=20030920053236.GA6632%40darby.dbaron.org
http://groups.google.com/groups?selm=mailman.1080267540.11846.mozilla-layout%40mozilla.org
http://groups.google.com/groups?selm=mailman.1080346500.9824.mozilla-layout%40mozilla.org

I think now is a good time to do this.  I plan to write a shell script that
contains all the moves and can be modified to do all the necessary steps, such as:
 * a 'mv' from old location to new location for testing the reorg in a tree and
writing the makefile changes
 * repository-copy from old location to new location
 * cvs tag removal on the new location
 * cvs up and cvs ci -f on the new locations to add a checkin comment about the move
 * rm and cvs rm on the old locations

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: use preprocessor instead of multiple files for forms.css (checked in 2004-11-29 22:04 -0800)

Comment 2

[Crispin Flowerday (not receiving bug mail)]

Attachment: fix "make install" bustage from previous patch (checked in 2004-11-30 14:19:45 -0800)

Unfortunately this patch broke my build, you can see a log at (its pretty
chunky):

http://patches.theflowerdays.com/tinderbox/logs/2004-11-30/trunk-mozilla.txt.gz


This patch seems to fix the "make install" stage for me.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: preliminary move list, almost completely based on previous reorg proposal

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: preliminary move list

This is updated a bit:	it fixes some errors, and skips localization stuff that
bsmedberg will probably reorganize shortly.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: move list, v. 2

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: move list, v. 3

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: diffs to existing files, v. 3

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: new files, v. 3

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: diffs to existing files, v. 3.1

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: move list, v. 3.2

v 3.2 updates for roc's nsScrollPortFrame removal

Comment 11

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: new files, v. 3.2

Comment 12

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: diffs to existing files, v. 3.3

Comment 13

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: move list, v. 3.3

Comment 14

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: an ls -R showing the key parts of the new structure

Comment 15

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: an ls -R showing the key parts of the new structure

Comment 16

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: diffs to existing files, v. 3.4

I forgot the packaging changes to add layout_printing.xpt.  I hope my
hand-edits to the mac project files are right!

Comment 17

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 168096 [details]
new files, v. 3.2

Hard to review well, but make it so!

Comment 18

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 168105 [details] [diff] [review]
move list, v. 3.3

Hard to review well, but make it so!

Comment 19

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 168110 [details] [diff] [review]
diffs to existing files, v. 3.4

Hard to review well, but make it so!

Comment 20

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

So this will be a little problem:

mozilla/content/base/src/Attic/nsTextFragment.cpp,v
mozilla/content/xul/content/src/Attic/nsXULAtomList.h,v
mozilla/content/xul/content/src/Attic/nsXULAtoms.h,v
mozilla/content/xul/content/src/Attic/nsXULAtoms.cpp,v

Comment 21

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I missed do_remove in mvlist for:

content/shared/Makefile.in
content/shared/.cvsignore
layout/html/Makefile.in
layout/html/.cvsignore
layout/html/base/Makefile.in
layout/html/base/.cvsignore
layout/html/document/Makefile.in
layout/html/document/.cvsignore
layout/html/forms/Makefile.in
layout/html/forms/.cvsignore
layout/html/style/Makefile.in
layout/html/style/.cvsignore
layout/html/table/Makefile.in
layout/html/table/.cvsignore

Comment 22

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Also:

content/html/style/.cvsignore
content/html/style/Makefile.in

Comment 23

[Crispin Flowerday (not receiving bug mail)]

Attachment: Fix make install

Make install doesn't seem to like empty EXPORTS sections in the makefile, it
causes nsinstall to be called with the wrong arguments, see:

http://patches.theflowerdays.com/tinderbox/logs/2004-12-09/trunk-mozilla.txt.gz

Comment 24

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fixed on 12-08.