27248 - Bug listings saved with .html extension

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, enhancement, P2)

Description

[Mark Hamby]

Patch should only take 5 minutes to evaluate and apply.

Patch Description:

This patch sets the filename on buglist.cgi, long_list.cgi,
and reports.cgi output so that when the page is saved the
extension is '.html'.

Problem Solved:

When saving Bugzilla output, a '.cgi' extension was used.
Mailing the report to someone meant that they could not
view the report as it was not interpreted as HTML.

Problem Not Solved:
This does not fix the problem when mailing the CGI output
to someone (using Netscape Messenger for Solaris).
There are a couple of other ways to do this which may
solve this problem, but this patch was the easiest to
implement.

Comment 1

[Mark Hamby]

Attachment: Patch to set save filename for Bugzilla output.

Comment 2

[Terry Weissman]

[e-mail] is the new owner of Bugzilla and Bonsai.  (For details,
see my posting in netscape.public.mozilla.webtools,
news://news.mozilla.org/38F5D90D.F40E8C1A%40geocast.com .)

Comment 3

[Mark Hamby]

This bug is a QUICK FIX to an annoying problem.  It can be applied
to Bugzilla with no known side affects (that I have found).
I can send a patch against the newest CVS version of Bugzilla if desired.

Mark

Comment 4

[Dave Miller [:justdave]]

Yipee, another one that's been sitting here for several months...

Comment 5

[Dave Miller [:justdave]]

OK, this has been checked in.

Comment 6

[Andreas Franke (gone)]

Could it be that the patch for long_list.cgi has a typos?
http://lxr.mozilla.org/mozilla/source/webtools/bugzilla/long_list.cgi#40 reads
print "Content-disposition: attachement; filename=bugzilla_bug_list.html\n\n";
whereas all the other instances say "attachment" instead.
Don't know if this has any effect, but shouldn't it be uniform?

Comment 7

[Dave Miller [:justdave]]

Hmm, yes, that is correct.  Let me see what I can do about that.

Comment 8

[Dave Miller [:justdave]]

OK, new bug cropped up...  IE5 chokes on this altogether.  The bug I've marked as 
blocking this one (bug 46897) suggests changing "attachment" to "inline".  Anyone 
know if that will break Navigator or Mozilla?  Assuming it doesn't break 
anything, checking in the patches on bug 46897 will fix this bug as a side effect 
:)  (thus the dependency)

Comment 9

[Jon Robertson]

I'm not sure why you say IE5 chokes on this.  What it *does* do is pop up 
a "File Download - You have chosen to download a file from this location" 
dialog whenever I do a query.

I thought it was just supposed to affect the File|Save As... dialog.

Comment 10

[Tara Hernandez]

Patches for 46897 checked in.  IE5 is now happy.  Everybody else still good
AFAICT

Comment 11

[Dave Miller [:justdave]]

In search of accurate queries....  (sorry for the spam)

Comment 12

[Gervase Markham [:gerv]]

Reopening. When doing File | Save As... in Netscape 4, IE 4 and Mozilla, the 
filename given for a buglist.cgi is still "buglist.cgi".

Gerv

Comment 13

[Chris Yeh]

pushing off to 2.16

Comment 14

[Christopher Hoess (gone)]

Changing keywords (patch was applied, we've regressed).

Comment 15

[Matthew Tuck [:CodeMachine]]

Moving to new Bugzilla product ...

Comment 16

[Christian Reis]

Let me try and do this

Comment 17

[Dave Miller [:justdave]]

From RFC 2616 (HTTP/1.1 specification) :

19.5.1 Content-Disposition

   The Content-Disposition response-header field has been proposed as a
   means for the origin server to suggest a default filename if the user
   requests that the content is saved to a file. This usage is derived
   from the definition of Content-Disposition in RFC 1806 [35].

        content-disposition = "Content-Disposition" ":"
                              disposition-type *( ";" disposition-parm )
        disposition-type = "attachment" | disp-extension-token
        disposition-parm = filename-parm | disp-extension-parm
        filename-parm = "filename" "=" quoted-string
        disp-extension-token = token
        disp-extension-parm = token "=" ( token | quoted-string )

   An example is

        Content-Disposition: attachment; filename="fname.ext"

   The receiving user agent SHOULD NOT respect any directory path
   information present in the filename-parm parameter, which is the only
   parameter believed to apply to HTTP implementations at this time. The
   filename SHOULD be treated as a terminal component only.

   If this header is used in a response with the application/octet-
   stream content-type, the implied suggestion is that the user agent
   should not display the response, but directly enter a `save response
   as...' dialog.

==================

What this means is....  we did it right the first time and Internet Explorer is
broken.

I think the way to fix this is check the UserAgent string for Internet Explorer,
and if it's IE, send the inline disposition as was put in place in bug 46897. 
All other browsers should get "attachment" as the disposition, according to the
RFC, unless anyone reports another browser that trips over it and tries to save
even if it's not a binary file, then we can add that browser's UA to the list.

Comment 18

[Dave Miller [:justdave]]

We are currently trying to wrap up Bugzilla 2.16.  We are now close enough to
release time that anything that wasn't already ranked at P1 isn't going to make
the cut.  Thus this is being retargetted at 2.18.  If you strongly disagree with
this retargetting, please comment, however, be aware that we only have about 2
weeks left to review and test anything at this point, and we intend to devote
this time to the remaining bugs that were designated as release blockers.

Comment 19

[Michael M]

I've been using Mozilla 0.9.7 on Linux, and when I tried to save the DVD-FAQ
(http://dvddemystified.com/dvdfaq.html), it created the directory 'dvdfaq_files'
(which was empty, as there were no images on the site), but didn't save
dvdfaq.html. I had to use Netscape 4.77 to download the page. =(

Comment 20

[Bradley Baetz (:bbaetz)]

Comment on attachment 5135 [details] [diff] [review]
Patch to set save filename for Bugzilla output.

This breaks searching on IE, so needs-work. (it also  won't apply any more)

I won't know if we can do this without breaking things - jth?

Comment 21

[Jouni Heikniemi]

IE sucks big time with this. But yes, there are almost perfect solutions
available, it just tends to get a bit ugly. The problem has been solved before
in several applications (webmails offering "save attachment" have a very similar
minefield of browser incompatibility). 

I'll see if I can find some old code to help with this.

Comment 22

[Dave Miller [:justdave]]

This WORKSFORME both with Mozilla 2002101009 and MSIE 5.2.2 on Mac OS X on the
current cvs tip.

I'm given a filename of "bugs-2002-10-29.html" in Mozilla (nice of it to include
today's date even :) , and "Bug List" in MSIE (which happens to be the title of
the page, appears to be a "Feature" of Internet Explorer, oh well)

See http://landfill.bugzilla.org/bugzilla-tip/buglist.cgi?product=WorldControl

I'm not sure what checkin fixed this, but it works now, for the browsers that
support it correctly, without breaking the ones that don't.