27254 - XPInstall blocked - can't get rid of confirmation dlg

Status: VERIFIED FIXED

(Core Graveyard :: Installer: XPInstall Engine, defect, P1)

Description

[Jimmy Lee]

Build: 2000-02-10-09-M14(WIN), 2000-02-10-08-M14(MAC), 2000-02-10-08-M14(LINUX)

1. From http://jimbob/trigger2.html, trigger any xpi file

RESULT:
XPInstall confirmation dialog appears.  No module name and location names 
appear.  Clicking OK or Cancel buttons do nothing.

EXPECTED RESULT:
Module name and Location names appear.  Clicking OK and Cancel buttons do 
something.

Comment 1

[Cathleen]

none of the regression fixes went in this afternoon fixed this MAJOR regression.

XPInstall does not work at all!  

Trying to look for help....  

Comment 2

[Cathleen]

triggering ANY xpinstall is blocked.

Confirmation dialog comes up, but missing module name and location name, and YOU 
CAN'T GET RID OF IT!  (clicking OK or Cancel does nothing)

Comment 3

[Cathleen]

unable to find any help...  :-(

Comment 4

[Doug Turner (:dougt)]

I have nothing better to do.  snagging from cathleen. 

Comment 5

[Cathleen]

Thanks Doug!  :-)

Comment 6

[Peter Trudelle]

cc danm

Comment 7

[Doug Turner (:dougt)]

This looks like a chrome bug.  We create a window from C.  The window.open url 
parameter is:

chrome://xpinstall/content/institems.xul

The dialog is pretty vanilla.  When the dialog accually gets opened, I see this 
on the console:

JavaScript Error: syntax error
URL: http://jimbob/institems.js, line 1


It looks like it is using the current page that I am on as some sort of base 
references.

The code that opens this window is here:

http://lxr.mozilla.org/seamonkey/source/xpinstall/src/nsXPInstallManager.cpp#176


ccing hyatt, and pinkerton.  You guys know anything about this?

Comment 8

[Doug Turner (:dougt)]

I belive that relative script tags in xul are broken.  I am trying to verify 
this.

Comment 9

[Doug Turner (:dougt)]

work around found. going to use absolute chrome url;s

cathleen. could you check this in?

Comment 10

[Doug Turner (:dougt)]

Attachment: absolute chrome url diff.

Comment 11

[Doug Turner (:dougt)]

I wrote up another bug which address the real problem:

http://bugzilla.mozilla.org/show_bug.cgi?id=27355

Comment 12

[Cathleen]

still waiting for the tree to open up...  

Comment 13

[Cathleen]

fix checked in for dougt.

Comment 14

[Jimmy Lee]

Build: 2000-02-11-09-M14(WIN), 2000-02-11-12-M14(MAC), 2000-02-11-11-M14(LINUX)

Back to normal.  We can trigger xpis again.