Closed Bug 272783 Opened 20 years ago Closed 20 years ago

--enable-libxul

Categories

(Toolkit :: Startup and Profile System, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: benjamin, Assigned: benjamin)

References

Details

Attachments

(1 file, 2 obsolete files)

Starting to get libxul building.
Attached patch Configure bits only. (obsolete) — Splinter Review
Here's what I'm thinking for the configure changes. This patch is useless
without an additional patch which sets LIBXUL_LIBRARY in some makefiles and
hook up the static build.
Depends on: 272843
*** Bug 201149 has been marked as a duplicate of this bug. ***
Depends on: 272957
Attached patch Working patch (obsolete) — Splinter Review
This patch builds and works. It should not affect the default build of anything
except xulrunner (I tested seamonkey and it doesn't break anything). It depends
on the other two bugs blocking this one.
Attachment #167644 - Attachment is obsolete: true
Comment on attachment 167796 [details] [diff] [review]
Working patch

Grr, I forgot -N
Attachment #167796 - Attachment is obsolete: true
Comment on attachment 167839 [details] [diff] [review]
--enable-libxul with toolkit/libxul

Shaver, I've overloaded darin, so maybe you can look at this one?
Attachment #167839 - Flags: first-review?(shaver)
Attachment #167839 - Flags: first-review?(shaver) → first-review+
Comment on attachment 167839 [details] [diff] [review]
--enable-libxul with toolkit/libxul

this patch looks really good to me.  my only comment was that we might want to
make the directory name be toolkit/library instead of toolkit/libxul since
there has been some discussion about the libxul name changing to something
else.
Attachment #167839 - Flags: second-review+
Fixed on trunk. I'll open another bug for the additional tiers.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Blocks: 273876
Flags: in-testsuite-
Component: XRE Startup → Startup and Profile System
QA Contact: nobody → startup
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: