to small row group is not pushed on next page

RESOLVED FIXED

Status

()

RESOLVED FIXED
14 years ago
12 years ago

People

(Reporter: bernd_mozilla, Assigned: bernd_mozilla)

Tracking

({testcase})

Trunk
x86
Windows XP
testcase
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

6.17 KB, text/html
Details
4.46 KB, patch
bzbarsky
: review+
bzbarsky
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

14 years ago
load testcase in print preview see that the second page is empty one should be
able to read last line. This is probably a dupe but I can't find it. I will
attach soon.
(Assignee)

Comment 1

14 years ago
Created attachment 167668 [details]
testacse
(Assignee)

Comment 2

14 years ago
Created attachment 167669 [details] [diff] [review]
patch
(Assignee)

Updated

14 years ago
Attachment #167668 - Attachment is patch: false
Attachment #167668 - Attachment mime type: text/plain → text/html
(Assignee)

Comment 3

14 years ago
Created attachment 167924 [details] [diff] [review]
revised patch
Attachment #167669 - Attachment is obsolete: true
(Assignee)

Updated

14 years ago
Attachment #167924 - Flags: superreview?(bzbarsky)
Attachment #167924 - Flags: review?(bzbarsky)
It'll take me a bit to get to this -- my net connection is spotty.... :(
(Assignee)

Updated

14 years ago
Status: NEW → ASSIGNED
Comment on attachment 167924 [details] [diff] [review]
revised patch

>Index: nsTableFrame.cpp

>+        aDesiredSize.height = borderPadding.bottom + GetCellSpacingY() +
>+                              lastChildReflowed->GetRect().YMost();

Why is this still adding in the cellspacing?  I don't think it should...

r+sr=bzbarsky with that fixed or a comment explaining why it's correct.
Attachment #167924 - Flags: superreview?(bzbarsky)
Attachment #167924 - Flags: superreview+
Attachment #167924 - Flags: review?(bzbarsky)
Attachment #167924 - Flags: review+
(Assignee)

Comment 6

14 years ago
the row groups are inset at the top by a border padding and a cellspacing this
is reflected in the YMost. But a table has the borderpadding bottom and  another
cellspacing below the table and this, as the cellspacing above the row group not
included (see CSS 2.1 "Next is the layer containing the row groups. Each row
group extends from the top left corner of its topmost cell in the first column
to the bottom right corner of its bottommost cell in the last column."). So I
believe the patch is correct.
Oh, if we're putting cellspacing below the last lowgroup then the patch is in
fact correct...
(Assignee)

Comment 8

14 years ago
fix checked in
Status: ASSIGNED → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.