Closed
Bug 273080
Opened 21 years ago
Closed 21 years ago
Remove double assignment in |fNextToken = nsIMAPGenericParser::GetNextToken()|
Categories
(MailNews Core :: Networking: IMAP, defect)
MailNews Core
Networking: IMAP
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: engel, Assigned: engel)
References
Details
Attachments
(1 file)
|
60.64 KB,
patch
|
Bienvenu
:
review+
dmosedale
:
superreview+
|
Details | Diff | Splinter Review |
Note that |char *nsIMAPGenericParser::GetNextToken()| is always invoked as
|fNextToken = GetNextToken()|. This is somewhat redundant, since
|GetNextToken()| actually returns |fNextToken|.
This double assignment should be removed, e.g., by replacing |char
*GetNextToken()| with |void AdvanceToNextToken()|. This makes the code more
readable and even shrinks the (non-debug) binary by ~1 KB.
|
Assignee | |
Comment 1•21 years ago
|
||
Trivial patch. Some comments needed word-wrapping.
|
|
Assignee | |
Updated•21 years ago
|
Attachment #167798 -
Flags: review?(bienvenu)
|
|
Assignee | |
Updated•21 years ago
|
Status: NEW → ASSIGNED
|
|
||
Updated•21 years ago
|
Attachment #167798 -
Flags: review?(bienvenu) → review+
|
|
Assignee | |
Updated•21 years ago
|
Attachment #167798 -
Flags: superreview?(dmose)
|
||
Comment 2•21 years ago
|
||
Comment on attachment 167798 [details] [diff] [review]
remove double assignment and replace GetNextToken by AdvanceToNextToken
sr=dmose ; nice bloat find!
Attachment #167798 -
Flags: superreview?(dmose) → superreview+
|
||
Comment 3•21 years ago
|
||
Fix landed by Neil:
2004-12-07 16:02
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
|
||
Updated•16 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•