Closed
Bug 273193
Opened 20 years ago
Closed 20 years ago
float:left is not placed correctly when inside an empty position:relative
Categories
(Core :: Layout: Block and Inline, defect)
Core
Layout: Block and Inline
Tracking
()
RESOLVED
FIXED
People
(Reporter: MatsPalmgren_bugz, Assigned: roc)
References
()
Details
(Keywords: regression, testcase)
Attachments
(3 files)
698 bytes,
text/html
|
Details | |
730 bytes,
text/html
|
Details | |
5.27 KB,
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
float:left is not placed correctly when inside an empty position:relative.
This is a regression from bug 209694.
STEPS TO REPRODUCE:
1. Load testcase
ACTUAL RESULTS:
blue box is placed at the left edge of the viewport.
EXPECTED RESULTS:
blue box indented 1.5em from the left edge of the viewport.
Reporter | ||
Comment 1•20 years ago
|
||
Reporter | ||
Comment 2•20 years ago
|
||
Adding a border, padding or an explicit height to the rel.pos. fixes it...
Updated•20 years ago
|
Flags: blocking1.8a6?
Comment 3•20 years ago
|
||
Roc's out and so he probably won't be getting to this in time for the alpha.
Setting a nomination now for beta.
Flags: blocking1.8b?
Flags: blocking1.8a6?
Flags: blocking1.8a6-
![]() |
||
Comment 4•20 years ago
|
||
This was introduced by the change to nsBlockReflowContext::PlaceBlock in bug
209694. The empty block now goes through a codepath that doesn't do relative
positioning and doesn't do correct horizontal alignment. That seems pretty
wrong to me....
Robert, if you don't have time to look into this, please let me know and I will.
Assignee | ||
Comment 5•20 years ago
|
||
The only reason this worked before was because the non-empty overflow area
stopped us from treating the block as empty --- which is definitely wrong. We
have to fix up this code so that empty blocks are correctly aligned and
relatively positioned.
Assignee | ||
Comment 6•20 years ago
|
||
This patch merges all the code that should be in common for both empty and
non-empty blocks.
Assignee | ||
Updated•20 years ago
|
Attachment #172315 -
Flags: superreview?(bzbarsky)
Attachment #172315 -
Flags: review?(bzbarsky)
![]() |
||
Comment 7•20 years ago
|
||
Comment on attachment 172315 [details] [diff] [review]
fix
r+sr=bzbarsky
Attachment #172315 -
Flags: superreview?(bzbarsky)
Attachment #172315 -
Flags: superreview+
Attachment #172315 -
Flags: review?(bzbarsky)
Attachment #172315 -
Flags: review+
Assignee | ||
Comment 8•20 years ago
|
||
checked in
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Updated•20 years ago
|
Flags: blocking1.8b?
You need to log in
before you can comment on or make changes to this bug.
Description
•