273200 - Ctrl+W in Find bar breaks middle-clicking links, find toolbar, and back button

Status: RESOLVED FIXED

(Toolkit :: Find Toolbar, defect)

Description

[Jesse Ruderman]

This happened to me once while I was using Mozilla/5.0 (Windows; U; Windows NT
5.1; en-US; rv:1.8a6) Gecko/20041203 Firefox/1.0+.  A bunch of stuff broke at
once in one window.  Other windows continued to work.

* Middle-clicking links stopped opening them in new tabs, and this error
appeared when I middle-clicked links:

Error: window._content has no properties

Source File: chrome://browser/content/contentAreaUtils.js

Line: 31

* The Find toolbar stopped finding, and this error appeared on every keypress
when I typed into it:

Error: uncaught exception: [Exception... "Component returned failure code:
0x80004005 (NS_ERROR_FAILURE) [nsIDOMXULElement.boxObject]"  nsresult:
"0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame ::
chrome://global/content/bindings/browser.xml :: get_docShell :: line 0"  data: no]

* The back button stopped working -- it remained disabled through page loads.

Comment 1

[Jesse Ruderman]

This has happened to me several times since I reported it.

Comment 2

[Dimitrios]

This doesn't seem to be an aviary-landing bug.

Comment 3

[Jesse Ruderman]

Still happening in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a6)
Gecko/20050107 Firefox/1.0+.

Comment 4

[Rob Marshall [tH]]

This just happened to me in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
rv:1.8b) Gecko/20050115 Firefox/1.0+. The Go menu was also broken (showing only
back, forward, home, history), and using the find toolbar gave this error:

Error: uncaught exception: [Exception... "Component returned failure code:
0x80004002 (NS_NOINTERFACE) [nsIInterfaceRequestor.getInterface]"  nsresult:
"0x80004002 (NS_NOINTERFACE)"  location: "JS frame ::
chrome://global/content/findBar.js :: getSelectionControllerForFindToolbar ::
line 209"  data: no]

However, the problem seemed to "fix itself", I think it was when I looked at the
History sidebar.

Comment 5

[Jesse Ruderman]

This is happening to me very frequently, usually right after I close a tab. 
Switching tabs fixes it.

Comment 6

[Jesse Ruderman]

I finally figured out how to reproduce this bug!  I don't know whether this is
the only way to break _content.

1. Make sure you have at least two tabs open.
2. Open the Find bar.
3. While the Find bar has focus, press Ctrl+W or Ctrl+F4.

Result: The tab closes as expected, but the following appears on the JS console:

Error: uncaught exception: [Exception... "Component returned failure code:
0x80004005 (NS_ERROR_FAILURE) [nsIDOMXULElement.boxObject]"  nsresult:
"0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame ::
chrome://global/content/bindings/browser.xml :: get_docShell :: line 0"  data: no]

4. Try to middle-click links in the tab that is now selected.

Result: Nothing happens, and the following error appears on the JS console:

Error: window._content has no properties
Source File: chrome://browser/content/contentAreaUtils.js
Line: 31

Workaround: switch tabs (open a new tab using Ctrl+T if necessary).

Comment 7

[Asaf Romano (gone)]

Jesse, does the patch from bug 278544 help?

Comment 8

[Asaf Romano (gone)]

Should be fixed in the next build, please test (bug 278544).

Comment 9

[Jesse Ruderman]

I still see this bug in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
rv:1.8b2) Gecko/20050303 Firefox/1.0+.

Comment 10

[Jesse Ruderman]

Still happens in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2)
Gecko/20050305 Firefox/1.0+, even though bug 274625 has been fixed as well.

Comment 11

[Anbo Motohiko]

Attachment: Simple patch.

The error in browser.xml occurs in onblur event of findbar.
http://lxr.mozilla.org/mozilla/source/toolkit/components/typeaheadfind/content/findBar.inc#8


I don't know exactly, but this might be caused by reference to contents of
closed tab.
http://lxr.mozilla.org/mozilla/source/toolkit/components/typeaheadfind/content/findBar.js#263

# ??? destroy current tab -> focus new tab -> onblur -> refer to destroyed tab
-> error ???

There are nothing to be changed its styles, so make quickly return from
changeSelectionColor().

Comment 12

[Anbo Motohiko]

Comment on attachment 177698 [details] [diff] [review]
Simple patch.

Does anyone take a look at this?

Comment 13

[Nickolay_Ponomarev]

*** Bug 282961 has been marked as a duplicate of this bug. ***

Comment 14

[Mike Connor [:mconnor]]

Comment on attachment 177698 [details] [diff] [review]
Simple patch.

r=me, with the following comment instead, since this won't always be in tabs:

// if we throw here, the browser we were in is already destroyed.
// see bug 273200

Comment 15

[Mike Shaver (:shaver emeritus)]

Comment on attachment 177698 [details] [diff] [review]
Simple patch.

a=shaver, with the comment fixed as mconnor requested.

Comment 16

[Steffen Wilberg]

Checking in mozilla/toolkit/components/typeaheadfind/content/findBar.js;
/cvsroot/mozilla/toolkit/components/typeaheadfind/content/findBar.js,v  <-- 
findBar.js
new revision: 1.7; previous revision: 1.6
done