273324 - Hang on unclosed comments in standards mode

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, defect)

Description

[Blake Kaplan (:mrbkap) (inactive)]

More fallout from bug 88952. I forgot a case where we call
CCommentToken::Consume(), and so on the above page, we never call ConsumeText()
(we just try to consume it as a comment over and over again).

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: patch v1

Since I could, I also now set unterminated comments (in standards mode only) as
in error in view-source. The specific fix for this bug is the block in
nsHTMLTokenizer::ConsumeSpecial(). There are no other places that create
comment tokens.

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 167976 [details] [diff] [review]
patch v1

Asking for r=. jst, if you feel like it, feel free to give r+sr=.

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 167976 [details] [diff] [review]
patch v1

As a note, in my tree, I've removed the calls to SetInError(), because if the
text following (in) the comment is longer than a packet, then the highlighting
in view-source will be inconsistant (It'll be <red>&lt;!-- Blah blah</red> blah
blah).

Comment 4

[Johnny Stenback (:jst)]

Comment on attachment 167976 [details] [diff] [review]
patch v1

r=jst, but requesting sr from bz.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 167976 [details] [diff] [review]
patch v1

Looks reasonable.  sr=bzbarsky

Comment 6

[Blake Kaplan (:mrbkap) (inactive)]

Checked in.