273417 - Make toolkit code use the app id, app version, app buildid from nsXULAppAPI instead of requiring prefs.

Status: RESOLVED FIXED

Description

[Benjamin Smedberg]

We now have a scriptable interface version of nsXULAppAPI. To make app setup and
bootstrap more sane, we shouldn't require the app id/version/buildid in prefs
also. This patch fixes things.

Comment 1

[Benjamin Smedberg]

Created attachment 168049 [details] [diff] [review]
use nsXULAppAPI data

Comment 2

[Darin Fisher]

Comment on attachment 168049 [details] [diff] [review]
use nsXULAppAPI data

>Index: toolkit/mozapps/plugins/content/pluginInstallerDatasource.js

>+  var app = Components.classes["@mozilla.org/xre/app-info;1"]
>+                      .getService(Components.interfaces.nsIXULAppInfo);
>+  this.appID = app.ID;
>+  /* xxxbsmedberg: should this be geckobuildid? aren't plugins versioned per-gecko, not per-app? */
>+  this.buildID = app.appBuildID;

yes, make it so :)


>Index: toolkit/mozapps/plugins/content/pluginInstallerWizard.js

>+  // xxxbsmedberg: should this be geckoBuildID intead of appBuildID?

ditto


>Index: toolkit/xre/nsAppRunner.cpp

>+      id = {0,0,{0,0,0,0,0,0,0,0}};

memset(&id, 0, sizeof(id));


> NS_IMETHODIMP
>+nsXULAppInfo::GetID(nsID** aResult)
>+{
>+  *aResult = NS_Alloc(sizeof(nsID));
>+  if (!*aResult)
>+    return NS_ERROR_OUT_OF_MEMORY;
>+
>+  **aResult = gAppData->id;
>+
>+  return NS_OK;
>+}

For interfaces that expose an nsID getter, we often provide a noscript
version that returns a shared pointer (nsIInterfaceInfo::getIIDShared)


r=darin with those changes

Comment 3

[Benjamin Smedberg]

Fixed on trunk, without the noscript iid-getter. We don't have any non-scripted
callers yet, and it doesn't look likely that we will. I can add one later if
necessary.

Comment 4

[Robert Accettura [:raccettura]]

http://lxr.mozilla.org/seamonkey/source/toolkit/xre/nsIXULAppInfo.idl#42

Right now the comment says it's unstable.  Is there any timeline when this will
be stable?  SeaMonkey 1.8?  Firefox 1.1?  Or is this further out?

Comment 5

[Benjamin Smedberg]

Yes, I intend to have a stable interface by 1.8/1.1, and it is likely that I
will try to freeze it.

Comment 6

[Robert Accettura [:raccettura]]

Cool.  I could make good use of that appBuildID.

Comment 7

[Dorando]

The patch seems to have ommited one gPref.getCharPref(PREF_EM_APP_VERSION) ->
gApp.version (
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/toolkit/mozapps/extensions/src/nsExtensionManager.js.in&rev=1.73#4256
)

Comment 8

[Benjamin Smedberg]

Dorando, thanks for noticing that, I have fixed it also.