273507 - Add 'set me as being /away' to [some] context menu

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, enhancement)

Description

[Karsten Düsterloh]

Now that CZ makes /away states visible in the user list, it would be very
convenient to have a user list context menu item that allows for setting one's
status to /away.
As a first step, a single, "pref'd" message would suffice, but multiple messages
(in a submenu) are an option...

Comment 1

[James Ross]

Putting it on the userlist context menu seems wrong, as that could be opened for
any user (so the item would have to be hidden mostly or something).

rginda's original idea (that I remember) was to have the server-nick (the label
to the left of the input) open a popup when clicked.

Comment 2

[Karsten Düsterloh]

> Putting it on the userlist context menu seems wrong, as that could be opened
> for any user (so the item would have to be hidden mostly or something).

Granted.

> rginda's original idea (that I remember) was to have the server-nick (the
> label to the left of the input) open a popup when clicked.

Ah, okay, good idea.

Comment 3

[James Ross]

Attachment: Split /away into /away and /back, and add menu to nickname

There's a bunch of whitespace changes in here too, generated by my editor, but
in general it only adds the menu onto a special button (don't ask about why I
had to implement it myself, XUL sucks). Also going in with this is the
downward-pointing arrow image to sit next to the text in the button.

This patch is based on what went into ChatZilla 0.9.68a.

Comment 4

[Asa Dotzler [:asa]]

Comment on attachment 182084 [details] [diff] [review]
Split /away into /away and /back, and add menu to nickname

a=asa

Comment 5

[James Ross]

Checked in --> part one done.

An automatic nightly ChatZilla build containing this fix will be available in
around 30 minutes from http://twpol.dyndns.org/mozilla/chatzilla/nightly/

Still to do: a list of away messages stored somewhere.

Comment 6

[James Ross]

Attachment: Add to jar.mn this time!

Comment 7

[[e-mail]]

What was wrong with using a <toolbarbutton type="menu">?
For an example, see the Suite sidebar's Tabs button.

Comment 8

[James Ross]

a) being unable to find anything in XUL's hidious mess of crap that worked right
at the time.
b) having absolutely no faith in any part of XUL working consistently, reliable
or at all over Mozilla 1.0 to present, thanks to it's inability to do so in
anything I've ever tried that is more complicated than <label/> or <vbox/>.

Comment 9

[[e-mail]]

Attachment: Use a toolbarbutton

Tested on Mozilla 1.0 using the Classic and Modern themes.
Tested on Suite Trunk using Classic, Modern, Pinball and Toy Factory themes.

Comment 10

[[e-mail]]

Attachment: Use toolbar

Also includes the diff for handlers.js which I forgot last time :-[

Comment 11

[James Ross]

Comment on attachment 184180 [details] [diff] [review]
Use toolbar

I guess I'll let you get away with this abuse of XUL, since it has totally
failed to provide anything useful.

r=silver

Comment 12

[[e-mail]]

Comment on attachment 184180 [details] [diff] [review]
Use toolbar

Chatzilla-only patch, but not urgent.

Comment 13

[Asa Dotzler [:asa]]

Comment on attachment 184180 [details] [diff] [review]
Use toolbar

moving request out to b3. We're very nearly wrapped up on 1.8b2.

Comment 14

[Mike Shaver (:shaver emeritus)]

Comment on attachment 184180 [details] [diff] [review]
Use toolbar

a=shaver

Comment 15

[[e-mail]]

Menu button checked in.

Comment 16

[:Gijs (he/him)]

I haven't got the time to investigate this thoroughly, but it seems the new
version of CZ starts with just an arrow where you'd normally have the nickname,
and no name next to it, in the modern theme. (using a less-than-a-month old
suite nightly build)
The nickname appears when you attempt to connect to any IRC server. However,
even when it does appear, there is no space between the image and the nickname,
making it look ugly and not neat. If what I'm seeing isn't caused by my own
modifications or cvs update screwing up, then I think this bug needs to be reopened.

Comment 17

[[e-mail]]

The lack of nickname is caused by createMenus being after
client.dispatch("set-current-view", { view : client });
Is it safe to create the menus earlier?

Comment 18

[James Ross]

No, the menus must be created after the plugins have loaded and run, and they
need to be after we have set the current view.

Comment 19

[[e-mail]]

Attachment: reset label

Also includes attempt at resolving the label/dropmarker issue.

Comment 20

[James Ross]

Comment on attachment 185192 [details] [diff] [review]
reset label

>+    // XXX creating the menus clears the nick, reset it
>+    client.statusBar["server-nick"].setAttribute("label", client.prefs["nickname"]);

I think it would be better to actually use the right label when creating the
menu, you know. Just put client.prefs["nickname"] as the label next to the
domID you added, I think.


>+.toolbarbutton-menu-dropmarker {
>+    margin-left: 5px;
>+}

This is no less hacky that what I had before... could you at least use EMs or
something that will not upset people who use varying font sizes?

Comment 21

[[e-mail]]

Attachment: Addressed review comments

Comment 22

[James Ross]

Comment on attachment 185302 [details] [diff] [review]
Addressed review comments

r=silver

I still don't like this, it looks horrible, but I suppose it is good the menu
opens more reliably...

Comment 23

[[e-mail]]

Regression fixes checked in.