273600 - Task Progress bar

Status: VERIFIED FIXED

(Calendar :: Tasks, enhancement)

Description

[Charles]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0

We should have have a progress bar as well as progress status for the tasks
it may be very usefull.
Thanks a lot

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

Actual Results:  
No progress bar

Expected Results:  
Have a progress bar for the tasks

Comment 1

[gekacheka]

Where would the progress bar be displayed?
In the tasks table, as background to the "% Complete" column for every task?

Comment 2

[Charles]

The progress bar should be placed in the %complete column as a background
Moreover the user could make the choice of display % complete value to see only
the progress bar.

thanks a lot for replying

Comment 3

[Joey Minta]

*** Bug 256712 has been marked as a duplicate of this bug. ***

Comment 4

[Matthew (lilmatt) Willis]

Reassigning all automatically assigned bugs from Mostafa to nobody@m.o

Bugspam filter: TorontoMostafaMove

Comment 5

[Philipp Kewisch [:Fallen][📱📆]]

I think this would clutter the UI too much, if you want to have an overview how finished your tasks are, then you can always sort by % completed.

My vote would be for WONTFIX [ extension fodder ]. This could probably be taken care of in an extension.

Charles, no hard feelings please. If you are interested, I can guide you to how to create an extension for this. Please contact me via email in that case.

Comment 6

[Jonatan Cloutier]

(In reply to comment #5)
> I think this would clutter the UI too much, if you want to have an overview how
> finished your tasks are, then you can always sort by % completed.
> 
I would tend to say that it's would simplify the UI. I rarely want to change my sort order to see which task is almost done and which still need lot of work. instead I sort by finish date and look at the %completed to see that info, but you almost have to sort all of this in your head instead of just looking at a progress bar that visually tell in a glimpse which task are which one.

> My vote would be for WONTFIX [ extension fodder ]. This could probably be taken
> care of in an extension.

shouldn't we ask more the community before doing that? considering it was in the proposal with the task mode and from what I remember no one discard it at that time[1]. It might need a little more discussion before choosing a WONTFIX

[1] in bug 253396   see also http://wiki.mozilla.org/Calendar:Task_Mode that was in comment #6

Comment 7

[Philipp Kewisch [:Fallen][📱📆]]

(In reply to comment #6)
> I would tend to say that it's would simplify the UI. I rarely want to change my
> sort order to see which task is almost done and which still need lot of work.
> instead I sort by finish date and look at the %completed to see that info, but
> you almost have to sort all of this in your head instead of just looking at a
> progress bar that visually tell in a glimpse which task are which one.
I'm just arguing, that a progress bar needs much more room that 2-3 digits and a % sign. While this is fine in the task view, its not so good for the small task tree in the today pane or in sunbird.

> shouldn't we ask more the community before doing that? considering it was in
> the proposal with the task mode and from what I remember no one discard it at
> that time[1]. It might need a little more discussion before choosing a WONTFIX
> 
> [1] in bug 253396   see also http://wiki.mozilla.org/Calendar:Task_Mode that
> was in comment #6
We had very many unconfirmed bugs and instead of asking on each bug, I made some decisions on certain bugs. I'm sorry, I have made the wrong decision here. Thanks for pointing that out, you are of course correct then. I didn't have the full task view in mind, just the small one.

Comment 8

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Add Progressmeters

As a small compensation, here the fix ;-)

Comment 9

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Screenshot linux

Comment 10

[Jonatan Cloutier]

(In reply to comment #7)
> I'm just arguing, that a progress bar needs much more room that 2-3 digits and
> a % sign. While this is fine in the task view, its not so good for the small
> task tree in the today pane or in sunbird.
>
agree with that.. in my case I didn't tough about the mini-task-unifinder. having seen your patch screenshot, you added a progress bar to both of them. I know it's the same object so a change to one affect the other, but if the %completed column is too small a progress bar isn't useful and in the mini-task-uni people would like to have a small column with a text %. this might be accomplish by showing text if the column is smaller then 20px and progress bar if longer. 

> We had very many unconfirmed bugs and instead of asking on each bug, I made
> some decisions on certain bugs. I'm sorry, I have made the wrong decision here.

yeah, I saw some of them and your are mostly right and it's something that needs to be done.

Comment 11

[Christian Jansen]

Comment on attachment 320694 [details] [diff] [review]
Add Progressmeters

Thanks for the patch. One minor glitch: The progress bar does not reflect the visual style of the system (tested on MAC OSX 10.5) (see attachment). But it would be OK for me, if we fix this in a separate bug. r=christian

Comment 12

[Christian Jansen]

Attachment: black progress bars

Comment 13

[Philipp Kewisch [:Fallen][📱📆]]

Could you provide a screenshot of what they should look like? I didn't change any progress bar styles at all.

Comment 14

[Christian Jansen]

sure...

see attachment &
http://developer.apple.com/documentation/UserExperience/Conceptual/OSXHIGuidelines/XHIGControls/chapter_19_section_5.html#//apple_ref/doc/uid/TP30000359-TPXREF208

Comment 15

[Christian Jansen]

Attachment: MAC OSX Progress bar

Comment 16

[Stefan Sitter [:ssitter]]

I'd recommend to check how the progress bar is displayed in Firefox 2 and Firefox 3 and compare it to Sunbird. Maybe the current look is already toolkit-native and will be fixed with the Cocoa widget adaption happened on Trunk.

Comment 17

[Berend Cornelius]

patch looks good and works almost fine. I have nothing to object.
>+          // The progress mode for a given cell. This method is only called for
>+          // columns of type |progressmeter|.
>+          getProgressMode: function mTV_getProgressMode(aRow, aCol) {
>+              switch(aCol.element.getAttribute("anonid")) {
>+                  case "calendar-task-tree-col-percentcomplete":
>+                      return Components.interfaces.nsITreeView.PROGRESS_NORMAL;
>+              }
>+
>+              return Components.interfaces.nsITreeView.PROGRESS_NONE;
I would use an if- statement instead of "switch" in this case but I am fine with this, too.
On nasty peculiarity I found can be seen in the attached graphic: Under Linux you have a repaint error when you minimize the column. As can be seen the progressmeter stretches in this case over all adjacent columns to the right.

Comment 18

[Berend Cornelius]

Attachment: Screenshot of the repaint error

Comment 19

[Berend Cornelius]

Comment on attachment 320694 [details] [diff] [review]
Add Progressmeters

As discussed with philipp on irc setting a minwidth at the column resoves the bad repaint behaviour. r=berend

Comment 20

[Philipp Kewisch [:Fallen][📱📆]]

Added the minwidth.

Unfortunately, I can't really influence the progressmeter in the tree much. I could change some colors, but that would be about it. The only user of the progressmeter in a <tree> is the xpfe download managers, so I believe not many people will be interested in fixing it.

Christian, if you provide me some colors (and border colors), I can add a fix for this.

Checked in on HEAD and MOZILLA_1_8_BRANCH

-> FIXED

Comment 21

[Philipp Kewisch [:Fallen][📱📆]]

Btw, I used a switch statement, in case we want to take care of other fields in the future. This makes the transition easier then.

Comment 22

[Christian Jansen]

Attachment: Screenshot of the repaint error

Comment 23

[Philipp Kewisch [:Fallen][📱📆]]

Christian, I set a minwidth on the cell. You are still getting the repaint error with the checked in patch? We might have to increase the minwidth.

Comment 24

[Christian Jansen]

No, I don't get the repaint error. Sorry for the confusion....

Comment 25

[Andreas Treumann]

Cheked in lightning 2008061918 and Sunbird 20080619 -> VERIFIED