273611 - Add end of list marker to SECErrorCodes enum in secerr.h

Status: RESOLVED FIXED

(NSS :: Libraries, enhancement, P2)

Description

[Nelson Bolyard (seldom reads bugmail)]

An NSS user writes:

In sslerr.h the error code enum ends with:
SSL_ERROR_END_OF_LIST   /* let the c compiler determine the value of this. */

this allows consumer code to check whether the count of error codes has changed
from version to version.

There is no analogous end marker in secerr.h though. Please add one so that
consumer code won't miss new error messages that get added.

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

Attachment: add end-of-list symbol

Comment 2

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 168178 [details] [diff] [review]
add end-of-list symbol

Saul, please review.

Comment 3

[Nelson Bolyard (seldom reads bugmail)]

saul, please review this patch.  Thanks.

Comment 4

[Saul Edwards]

Comment on attachment 168178 [details] [diff] [review]
add end-of-list symbol

Spacing look funny before/after the equals sign.  Otherwise OK.

Comment 5

[Nelson Bolyard (seldom reads bugmail)]

Checking in secerr.h;
/cvsroot/mozilla/security/nss/lib/util/secerr.h,v  <--  secerr.h
new revision: 1.17; previous revision: 1.16

Thanks for the review, Saul.  I fixed the whitespace and checked in.