An NSS user writes: In sslerr.h the error code enum ends with: SSL_ERROR_END_OF_LIST /* let the c compiler determine the value of this. */ this allows consumer code to check whether the count of error codes has changed from version to version. There is no analogous end marker in secerr.h though. Please add one so that consumer code won't miss new error messages that get added.
Comment on attachment 168178 [details] [diff] [review] add end-of-list symbol Saul, please review.
Attachment #168178 - Flags: review?(saul.edwards.bugs)
saul, please review this patch. Thanks.
Status: NEW → ASSIGNED
Comment on attachment 168178 [details] [diff] [review] add end-of-list symbol Spacing look funny before/after the equals sign. Otherwise OK.
Attachment #168178 - Flags: review?(saul.edwards.bugs) → review+
Priority: -- → P2
Target Milestone: --- → 3.10
Checking in secerr.h; /cvsroot/mozilla/security/nss/lib/util/secerr.h,v <-- secerr.h new revision: 1.17; previous revision: 1.16 Thanks for the review, Saul. I fixed the whitespace and checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.