273678 - nsChromeRegistry::ProcessNewChromeBuffer never flushes the profile chrome.rdf

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Darin Fisher]

nsChromeRegistry::ProcessNewChromeBuffer never flushes the profile chrome.rdf

I noticed while playing around with xulrunner that chrome.rdf was not getting
created in the profile directory.  I believe this may somehow be a regression
from the way things worked prior to the aviary branch landing or perhaps prior
to some other trunk changes.  At any rate, while investigating that problem I
noticed that  nsChromeRegistry::ProcessNewChromeBuffer flushes the chrome.rdf
that lives in the install directory irregardless of whether or not changes were
made to the install- relative data source.  It seems to me that we should flush
whichever data source is modified (or both).

Patch coming up...

Comment 1

[Darin Fisher]

Attachment: v1 patch

this patch does the trick.

i think previously that the profile-relative chrome.rdf was getting written out
at shutdown time.  now, on the trunk i only see a warning coming from the XML
RDF datasource about not being able to flush after xpcom-shutdown.  it seems
some shutdown sequencing has changed.  at any rate, this patch still seems like
the right thing to do.

Comment 2

[Darin Fisher]

fixed-on-trunk

Comment 3

[Benjamin Smedberg]

Dead code, no need for retroactive testcase