273812 - Mac widget code needs to stop using docshells

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Boris Zbarsky [:bzbarsky]]

At the moment, the mac menu code uses nsIWebShell all over.

With the removal of that interface in bug 273319, I'm switching the code over to
nsIDocShell.

Really, though, we shouldn't be using docshell stuff here at all.  It looks like
it's mostly used to get prescontexts for event dispatch.  Just using DOM events
(for the event types we can use them for) would have the same effect.  Neil says
the COMMAND events can't be done via DOM events, but can be done via
nsIDOMXULElement::DoCommand.

Fixing this would let us move on ahead with fixing the docshell apis to the
point where we can freeze them...

Comment 1

[Josh Aas]

Attachment: fix v1.0

This gets rid of all docshell usage from Cocoa widgets.

Comment 2

[Josh Aas]

Attachment: fix v1.0.1 (bump uuid)

Comment 3

[Josh Aas]

Attachment: fix v1.0.2

Turns out we can get rid of webshell too.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 280965 [details] [diff] [review]
fix v1.0.2

>Index: widget/src/cocoa/nsMenuBarX.mm

>+  domNode->GetOwnerDocument(getter_AddRefs(domDoc));
>+  if (domDoc) {
>+    nsCOMPtr<nsIDocument> doc(do_QueryInterface(domDoc));

do_QI is null-safe.  So no need to null-check domDoc.  And once you remove that check, you no longer need the addedMutationObserver boolean; just bail out if |doc| is null.

With that change, sr=bzbarsky

Comment 5

[Josh Aas]

landed on trunk with boris's change