27419 - Mozilla crashes when running test scripts off internal server

Status: VERIFIED FIXED

(Core :: DOM: Navigation, defect, P1)

Description

[Tom Everingham]

Overview Description:  Seeing a crash when I try to access my cookie test
scripts off of internal server.

Steps to Reproduce:
1.)  Go to site
2.)  Click on link to run script (Set name1=value1)

Actual Results:  Crash

Expected Results:  Scripts should run 

Build Date & Platform Bug Found:
NT 2000021008

Additional Builds and Platforms Tested On:
Linux 2000020908

Additional Information:

From talkback:
Call Stack:    (Signature = nsWebShell::GetTarget e6c1d071) 
nsWebShell::GetTarget 
[d:\builds\seamonkey\mozilla\webshell\src\nsWebShell.cpp, line 2790]
nsDocShell::GetTarget 
[d:\builds\seamonkey\mozilla\docshell\base\nsDocShell.cpp, line 1700]
nsWebShell::OnLinkClick 
[d:\builds\seamonkey\mozilla\webshell\src\nsWebShell.cpp, line 2770]
nsWebShell::HandleLinkClickEvent 
[d:\builds\seamonkey\mozilla\webshell\src\nsWebShell.cpp, line 2886]
OnLinkClickEvent::OnLinkClickEvent 
[d:\builds\seamonkey\mozilla\webshell\src\nsWebShell.cpp, line 2743]
PL_HandleEvent 
[d:\builds\seamonkey\mozilla\xpcom\threads\plevent.c, line 527]
PL_ProcessPendingEvents 
[d:\builds\seamonkey\mozilla\xpcom\threads\plevent.c, line 490]
_md_EventReceiverProc 
[d:\builds\seamonkey\mozilla\xpcom\threads\plevent.c, line 977]
USER32.dll + 0x1268 (0x77e71268) 
                                       
The scripts run fine if I type in their url without going through the
links.  ie.  http://slip/projects/dogbert/test/web/internal/cookies/name1.cgi

Comment 1

[travis]

Mscott and I have some code that will fix targetting.  When he gets back on 
Monday, we will land that code and hopefully also get rid of this bug.

Comment 2

[don]

M14.

Comment 3

[leger]

Putting on PDT+ radar for beta1.

Comment 4

[travis]

The stack trace is old because the new targetting code is in.  But I just 
tested this with the new targetting code and we run into a couple of problems.  
mscott and I just talked about them and he is going to fix them and then I'll 
review them.  Reassigning to him for now.

Comment 5

[Scott MacGregor]

Using a commercial build from today, I didn't see a crash, but the document was
loaded in the current web page instead of creating a new window called "cookie".

Comment 6

[Scott MacGregor]

I believe I have a fix for this. I'm probably going to sit on it tonight and
make sure I didn't break anything. Then I'll check it in tomorrow.

Comment 7

[Scott MacGregor]

Attachment: Proposed patch to fix the retargeting problem.

Comment 8

[Scott MacGregor]

Fix
checked
in.
We
now
bring
up
anew
window
if
thetarget
does
not
exist
already.

Comment 9

[leger]

Updating QA Contact for verification.

Comment 10

[Tom Everingham]

verified working on:
NT 2000022108
Linux 2000022108
Mac 2000022108