274271 - blocked install notification bar does not appear when clicking on InstallTrigger link

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Bill Gianopoulos [:WG9s]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a6) Gecko/20041211 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a6) Gecko/20041211 Firefox/1.0+

If a non-whielisted site tries to install software, the notifcation bar
informing the user of this does not appear.

Reproducible: Always
Steps to Reproduce:
1. Remove update.mozilla.org from the Install whitelist
2. Go to Tools -> Extensions -> Get more extensions
3. Select any extesnsion and click on the "Install Now" link

Actual Results:  
Absoulutely nothing (install blocked, but no notfication bar)

Expected Results:  
Disaplyed the notfication bar at the top of the browser main window explianing
that a software install was blocked and giving the user the option to change
settings.

Comment 1

[Phil Ringnalda (:philor)]

Only with installs using InstallTrigger, right? With 20041209, I get the infobar
with a direct link to an .xpi, and nada with an InstallTrigger.Install().

Comment 2

[Phil Ringnalda (:philor)]

Attachment: installation testcase

One InstallTrigger link, one direct .xpi link

Comment 3

[Bill Gianopoulos [:WG9s]]

Yes, I should have mentioned that.  Appears to only be an issue with install
trigger links.

Comment 4

[Bill Gianopoulos [:WG9s]]

I just noticed that bug 241705 now has an aviary-landing keyword saying that all
the code for this UI has not yet been checked in.  So, my guess is that is what
is causing this issue.

Comment 5

[Bill Gianopoulos [:WG9s]]

*** Bug 283914 has been marked as a duplicate of this bug. ***

Comment 6

[Ryan VanderMeulen [:RyanVM]]

I'm assuming this will be taken care of prior to 1.1's release?

Comment 7

[Grayson Mixon (ColdFusion650)]

wfm Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050326
Firefox/1.0+

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050325
Firefox/1.0+

You sure about that? Still not working for me.  You opened the test case and
clicked the InstallTrigger link? And the information bar appeared when you did?
You're certain?

Comment 9

[PikeUK]

*** Bug 289822 has been marked as a duplicate of this bug. ***

Comment 10

[Jed B]

Confirmed not working in the latest DearPark Release Candidate (from Asa's blog).
A few URLs to test this on:
http://toolbar.a9.com/
http://extensions.jedbrown.net/
http://quicknote.mozdev.org/installation.html

Comment 11

[Robert Strong (they/them - no direct email)]

Attachment: patch

This adds the code that is missing from the patch in bug 241705.

Comment 12

[Robert Strong (they/them - no direct email)]

Attachment: patch

Sorry, I missed a couple of brace style fixes in the first patch

Comment 13

[Ryan VanderMeulen [:RyanVM]]

I just applied the patch to my source tree and can confirm that the testcase now
works perfectly and other sites using InstallTrigger (such as
forecastfox.mozdev.org) also work now.

Comment 14

[:Gavin Sharp [email: [e-mail]]]

*** Bug 248486 has been marked as a duplicate of this bug. ***

Comment 15

[Daniel Veditz [:dveditz]]

Comment on attachment 184379 [details] [diff] [review]
patch

r/sr=dveditz, makes trunk match the branch.

Comment 16

[Asa Dotzler [:asa]]

Comment on attachment 184379 [details] [diff] [review]
patch

a=asa (time is short for 1.1a1 so please get this in quickly)

Comment 17

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Landed this on trunk as per Asa's request

Comment 18

[Asa Dotzler [:asa]]

Resolving. Thanks, vlad.

Comment 19

[Bob Clary [:bc] (inactive)]

testcase shows notification bar for me for both trigger and direct link in deer
park alpha 1
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050524
Firefox/1.0+

Comment 20

[Asa Dotzler [:asa]]

I've also verified this on today's linux builds under FC3. The notification bar
works as expected.

Comment 21

[Steffen Wilberg]

Removing aviary-landing keyword.

Comment 22

[Worcester12345]

(In reply to comment #21)
> Removing aviary-landing keyword.
> 

? Was it not?

Comment 23

[Steffen Wilberg]

It *was*. We've been asked not to reopen fixed bugs, but just add the keyword, and remove it once the issue had been resolve, so people cc'ed on dependent bugs don't receive so much bugspam. So the aviary-landing keyword only tracks the *remaining* issues. There are 6 bugs left.