27457 - Change Mozilla build system to pick up NSPR 4.0

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect, P3)

Description

[Wan-Teh Chang]

We want to have Mozilla pick up NSPR 4.0.
The library name change from libnspr3 to
libnspr4 requires modifying the Unix and
Windows makefiles.  On the Mac, NSPR
library's name hasn't changed for a long
time, so no change to the Mac build system
is required this time.

Another change is the NSPR cvs tag to pull.

Comment 1

[John G. Myers]

Attachment: proposed fix for unix, exclyding client.mk pull tag

Comment 2

[John G. Myers]

I have a brute-force patch for Windows, I'm cleaning it up to use macros better 
so this won't be such a pain next time.

Comment 3

[Wan-Teh Chang]

You can define NSPR_VERSION=4 in mozilla/config/config.mak
and use $(NSPR_VERSION) in NSPR library names.

Comment 4

[cls]

For Unix, r=cls.  I'm assuming the nspr autoconf build has been updated with the
new version number as well? :-)

Comment 5

[Wan-Teh Chang]

cls: good catch. Do I just need to change NSPR_VERSION
in mozilla/nsprpub/configure.in and
mozilla/nsprpub/configure?

Comment 6

[John G. Myers]

Strange...I've been building nspr's NSPR_RELEASE_4_0_BRANCH using autoconf, 
starting from the mozilla directory.  It's been working fine.

Comment 7

[cls]

Yes and NSPR_MODNAME as well if it has changed.

Comment 8

[cls]

By default, Mozilla uses the classic build system under nsprpub rather than
autoconf.  If we can verify that the nspr autoconf build works for more
platforms than just Linux & Solaris, we will change that.

Comment 9

[Wan-Teh Chang]

cls, is it possible to change webshell/embed/gtk/lib/Makefile.in
so that it gets the value of NSPR_VERSION set by mozilla/configure?

Comment 10

[cls]

Attachment: Pass value of NSPR_VERSION to subconfigure.

Comment 11

[John G. Myers]

Attachment: Proposed fix for windows

Comment 12

[srinivas]

Attachment: Checked in attachment 5181, except for the NSPR version number change. Diffs are attached.

Comment 13

[srinivas]

Attachment: Patch to pull NSPRPUB_4_0_BETA_20000215 and up NSPR_VERSION to 4.

Comment 14

[Wan-Teh Chang]

I just checked in attachment 5269 [details] [diff] [review].
1. Pull new NSPR tag NSPRPUB_4_0_BETA_20000215:
mozilla/client.mk, rev 1.78
mozilla/client.mak, rev 3.63
mozilla/build/mac/NGLayoutBuildList.pm, rev 1.439
2. Bump NSPR_VERSION to 4:
mozilla/configure, rev 1.456
mozilla/configure.in, rev 1.574
mozilla/config/config.mak, rev 3.87

Comment 15

[John G. Myers]

You should pull a tag of NSPR which includes revision 3.2.58.1 of 
pr/src/md/mac/prcpucfg.h.  Otherwise, you're going to have binary compatibility 
problems on Mac.

Comment 16

[Daniel (Leaf) Nunes]

compatibility problems with what?

Comment 17

[Wan-Teh Chang]

The current tag (NSPRPUB_4_0_BETA_20000215) does
not contain the new version of pr/src/md/mac/prcpucfg.h.
However, when NSPR 4.0 is released, mozilla will be
changed to pull the formal 4.0 release tag, which
will contain the new revision of pr/src/md/mac/prcpucfg.h.

Comment 18

[John G. Myers]

Compatibility problems with future versions of NSPR 4.x which include that 
change.

Comment 19

[Wan-Teh Chang]

My checkin (attachment 5269 [details] [diff] [review]) will need to be backed
out because it causes mozilla's bloaty test to hang
on exit.

Comment 20

[Wan-Teh Chang]

My checkin (attachment 5269 [details] [diff] [review]) has been backed out
because it causes mozilla's bloaty test to hang
on exit.

I believe I found the problem: the 'depend' target
in mozilla/Makefile does not do a make depend in
the nsprpub directory, so the nspr files did
not get recompiled after they were updated.  This
can be verified by the Tinderbox log file.

Comment 21

[John G. Myers]

I had a similar dependency problem on windows--I had to do a clobber in order to 
pick up the new definiton of PR_AF_INET6.

Comment 22

[Wan-Teh Chang]

Right.  I didn't add the "depend: clean" hack to
NSPR's Windows makefile until this morning.

The "depend: clean" hack causes make depend to
do a make clean in the tree, forcing a complete
rebuild.  This hack is in NSPR's Unix makefile.
Unfortunately, mozilla's make depend does not
recurse into the nsprpub directory on Linux.

Comment 23

[Wan-Teh Chang]

Second try.  Approved by [e-mail].  Have mozilla
pull NSPRPUB_RELEASE_4_0_20000218 (NSPR 4.0 release candidate)
and change NSPR_VERSION to 4.

/cvsroot/mozilla/client.mak, revision 3.65
/cvsroot/mozilla/client.mk, revision 1.81
/cvsroot/mozilla/configure, revision 1.461
/cvsroot/mozilla/configure.in, revision 1.579
/cvsroot/mozilla/build/mac/NGLayoutBuildList.pm, revision 1.444
/cvsroot/mozilla/config/config.mak, revision 3.89

Comment 24

[Wan-Teh Chang]

All tinderbox builds have cycled once without problems
since my checkin. Marked the bug fixed.