Closed Bug 274589 Opened 20 years ago Closed 16 years ago

citizensbankonline.com - Java Script Warnings

Categories

(Tech Evangelism Graveyard :: English US, defect)

Product:
Tech Evangelism Graveyard
Component:
English US
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WORKSFORME

People

(Reporter: smorada.j, Unassigned)

References

(
URL
)

Details

Attachments

(1 file)

HTML as provided by reporter
2.85 KB, text/html
Details 
This error started occurring when I upgraded from Firefox 0.9x to 1.0.  When I'm
in online banking and hit the "Submit" button, nothing happens.  The JavaScript
console shows:

Warning: Element referenced by ID/NAME in the global scope. Use W3C standard
document.getElementById() instead.
Source File: https://www.citizensbankonline.com/banking/transfer_select.htm
Line: 9

And the code is:

<html>
<head>
<META HTTP-EQUIV="expires" CONTENT="Mon, 31 Dec 2001 23:59:59 GMT"> 
<META HTTP-EQUIV="Pragma" CONTENT="no-cache"> 
<title>Transfer Funds</title>
<SCRIPT ID=clientEventHandlersJS LANGUAGE=javascript>
<!--
function submitonce(theform){ 

THIS IS THE LINE THAT WAS HIGHLIGHTED
if (trans_1.all||trans_1.getElementById) { 
END OF HIGHLIGHTED LINE

for (i=0;i<theform.length;i++) { 
var tempobj=theform.elements[i] 
if(tempobj.type.toLowerCase()=="submit"||tempobj.type.toLowerCase()=="reset") 
tempobj.disabled=true
 }
 } 
 else 
 return false
 } 
 
function isvalid(xx)
{
	var flag = 0;
	var i;
	for(i=0;i != 10;i++)
	{
	if (xx == i)
		{
		flag = flag + 1
		}
	}
	if (xx == '.')
		{
		flag = flag + 1
		}
	if (flag == 1)
		return true;
	else
		return false;
}



//-->
</SCRIPT>

</head>

<body bgcolor="#FFFFFF">
<table cellpadding="4" cellspacing="0" border="0" width="450">
<tr>
	<td valign="top" colspan="2">
	<!-- Transfer Form -->

	<font face="arial" span style="font-size: 14.0pt" color="#666666">Transfer
Funds</font>
	</td>
	<td>
	<form action="/index_logout.asp" method="post" name="LOGOFF" id="LOGOFF"
target="_top" style="display:inline" onSubmit="return submitonce(this)"><input
type="Hidden" name="ADFUNC" value="LOGOFF"><input type="Image" align="right"
valign="top" src="/images/LOGOFF.gif" id=image1 name=image1>
	</form>
	</td>
</tr>
</table>

<form name="trans_1" id="trans_1" action="/scripts/sdk/adinetin.dll"
method="POST" onSubmit="return submitonce(this)">

<input type="hidden" name="ADFUNC" value="SHOW_TRANSFER">


<table cellpadding="4" cellspacing="0" border="0" width="450">
<font face="arial" span style="font-size: 10.0pt" color="#666666">Please select
the type of transfer you wish to perform.</font><br><br>
<input name="OXFR1_XFRTYPE_1" type="radio" CHECKED value="ONE"><font
face="arial" span style="font-size: 10.0pt" color="#666666">Make a transfer
today</font><br>
<input name="OXFR1_XFRTYPE_1" type="radio" value="FUT"><font face="arial" span
style="font-size: 10.0pt" color="#666666">Set up a future dated transfer</font><br>
<input name="OXFR1_XFRTYPE_1" type="radio" value="REC"><font face="arial" span
style="font-size: 10.0pt" color="#666666">Set up a recurring transfer</font><br>
<input name="OXFR1_XFRTYPE_1" type="radio" value="REV"><font face="arial" span
style="font-size: 10.0pt" color="#666666">Review/Modify a recurring or future
dated transfer</font><br>
<br>
<tr>
<td>

<input type="image" src="/images/submit.gif" id=image1 name=image1>
</td>
</tr>

</table>         



</form>

 

<p>&nbsp;</p>
<table border="0" cellpadding="4" cellspacing="0" width="76%">
  <tr>
    <td width="100%">
      <p align="center"><img border="0" src="/images/fdicehl1.gif" width="233"
height="25"></td>
  </tr>

</table>

 

</body>

</html>
Version: unspecified → 1.0 Branch
This is the HTML as provided by the reporter, with an additional <base
href="https://www.citizensbankonline.com/banking/"> so that the images show.

The submitonce() function tries to detect something(?) by checking for either
"trans_1.all" (where trans_1 is the ID of a form element) or
"trans_1.getElementById".
The fact that "trans_1" is used (and not "document", or
document.getElementById('trans_1')) accounts for the warnings in the console.

trans_1.all returns a collection in IE, and "undefined" in Firefox.
trans_1.getElementById returns "undefined" in all the browsers I checked (FF,
IE, and Opera). Perhaps this was an attempt at Mozilla-detection? It's pretty
lame as such (documnt.getElementById would have worked).

Anyway, this is probably Tech. Evangelism.
Assignee: bugs → english-us
URL: https://www.citizensbankonline.com/ba...
Component: JavaScript Console → English US
Product: Firefox → Tech Evangelism
QA Contact: firefox.js-console → english-us
Summary: Java Script Warnings → citizensbankonline.com - Java Script Warnings
Version: 1.0 Branch → unspecified
Blocks: 124594
I still see the warnings, but the Submit button definitely works now. WORKSFORME? I don't have an account, so I can't really test this properly, but if it's working for you, Jon, you can mark this WORKSFORME (or I can if you tell me it works).
OS: Windows XP → All
Hardware: PC → All
WORKSFORME, since no one has given any arguments to the contrary in a month.
Status: UNCONFIRMED → RESOLVED
Closed: 16 years ago
Resolution: --- → WORKSFORME
Product: Tech Evangelism → Tech Evangelism Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: