274672 - Pressing Enter in Wizard activate BOTH focused button and pageAdvance()

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Leung Wing Chung]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0

Expected behavior:
a. If a button is focused, activate the focused button,
b. otherwise, activate pageAdvance()

Reproducible: Always

Steps to Reproduce:

Comment 1

[Leung Wing Chung]

Attachment: Patch of mozilla/toolkit/content/widgets/wizard.xml

Removed wrong check of dlgType="button"
If localName check is not enough, check also for the namespace.

Comment 2

[Leung Wing Chung]

Attachment: Testcase (Install and then open chrome://testwizard/content/testwizard.xul)

Comment 3

[Boris Zbarsky [:bzbarsky]]

xpfe/global/resources/content/bindings/wizard.xml needs the same change...

Comment 4

[Ian Neal]

Attachment: Patch for both wizard.xmls v0.2 (checked in)

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 171632 [details] [diff] [review]
Patch for both wizard.xmls v0.2 (checked in)

sr=bzbarsky.  Ian, can you check this in when the tree reopens?

Comment 6

[Stefan Borggraefe]

*** Bug 238794 has been marked as a duplicate of this bug. ***

Comment 7

[Ian Neal]

Comment on attachment 171632 [details] [diff] [review]
Patch for both wizard.xmls v0.2 (checked in)

Checking in toolkit/content/widgets/wizard.xml;
/cvsroot/mozilla/toolkit/content/widgets/wizard.xml,v  <--  wizard.xml
new revision: 1.17; previous revision: 1.16
done
Checking in xpfe/global/resources/content/bindings/wizard.xml;
/cvsroot/mozilla/xpfe/global/resources/content/bindings/wizard.xml,v  <-- 
wizard.xml
new revision: 1.21; previous revision: 1.20
done