Closed Bug 274964 Opened 20 years ago Closed 20 years ago

Switch to Expat's xml declaration parsing

Categories

(Core :: XML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: peterv, Assigned: peterv)

Details

Attachments

(1 file)

 
Attached patch v1Splinter Review
Attachment #168885 - Flags: superreview?(jst)
Attachment #168885 - Flags: review?(jst)
Comment on attachment 168885 [details] [diff] [review]
v1

Nice! r+sr=jst
Attachment #168885 - Flags: superreview?(jst)
Attachment #168885 - Flags: superreview+
Attachment #168885 - Flags: review?(jst)
Attachment #168885 - Flags: review+
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
This checkin breaks Solaris build, because the 3rd argument of
nsXMLContentSink::HandleXMLDeclaration is a |const PRInt32| 
(http://lxr.mozilla.org/seamonkey/source/content/xml/document/src/nsXMLContentSink.cpp#1235)
but in idl-generated nsIExpatSink.h, its just a |PRInt32|. This mismatch causes
libgklayout module failed to load on Solaris, non-debug build.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: