Closed Bug 275075 Opened 20 years ago Closed 20 years ago

two-arg form of do_GetServiceFromCategory always crashes

Categories

(Core :: XPCOM, defect)

Product:
Core
Component:
XPCOM
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: shaver, Assigned: shaver)

Details

(Keywords: crash)

Attachments

(1 file)

Check mErrorPtr before deref
546 bytes, patch
benjamin
: review+
darin.moz
: superreview+
Details | Diff | Splinter Review 
We unconditionally dereference mErrorPtr, but it defaults to 0.  Obvious patch
coming up.

        Attachment #168977 -
        Flags: superreview?(darin)

        Attachment #168977 -
        Flags: review?(bsmedberg)

    
  

        Attachment #168977 -
        Flags: review?(bsmedberg) → review+

    
    

    
  
Comment on attachment 168977 [details] [diff] [review]
Check mErrorPtr before deref

sr=darin

hmm... looks like the declaration of do_GetServiceFromCategory in
nsServiceManagerUtils.h should be #ifndef MOZILLA_STRICT_API as well :(

        Attachment #168977 -
        Flags: superreview?(darin) → superreview+

    
    

    
  
or that declaration should be moved into some other header file.

    
    

    
  
Thanks for reviews, fix committed.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED

    
  
Severity: normal → critical
Keywords: crash

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: