Closed
Bug 275075
Opened 21 years ago
Closed 21 years ago
two-arg form of do_GetServiceFromCategory always crashes
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: shaver, Assigned: shaver)
Details
(Keywords: crash)
Attachments
(1 file)
|
546 bytes,
patch
|
benjamin
:
review+
darin.moz
:
superreview+
|
Details | Diff | Splinter Review |
We unconditionally dereference mErrorPtr, but it defaults to 0. Obvious patch
coming up.
|
Assignee | |
Comment 1•21 years ago
|
||
Attachment #168977 -
Flags: superreview?(darin)
Attachment #168977 -
Flags: review?(bsmedberg)
|
||
Updated•21 years ago
|
Attachment #168977 -
Flags: review?(bsmedberg) → review+
|
||
Comment 2•21 years ago
|
||
Comment on attachment 168977 [details] [diff] [review]
Check mErrorPtr before deref
sr=darin
hmm... looks like the declaration of do_GetServiceFromCategory in
nsServiceManagerUtils.h should be #ifndef MOZILLA_STRICT_API as well :(
Attachment #168977 -
Flags: superreview?(darin) → superreview+
|
|
||
Comment 3•21 years ago
|
||
or that declaration should be moved into some other header file.
|
|
Assignee | |
Comment 4•21 years ago
|
||
Thanks for reviews, fix committed.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•