275096 - Page Info | Media | Save As button non-functional

Status: RESOLVED FIXED

(Firefox :: Page Info Window, defect)

Description

[Mike Pesce (:By-Tor)]

When clicking on the Save As button in Page Info->Media absolutely nothing
happens.  This bug was first noticed in builds after 12/15 but may have occured
earlier.

Comment 1

[Fred Collier]

'Save As' does NOT work.

Mozilla/5.0 (Windows; U; Win95; en-US; rv:1.8a6) Gecko/20041217 Firefox/1.0+ Exe

Comment 2

[Mike Pesce (:By-Tor)]

Why has this been marked aviary-landing?

Comment 3

[Nickolay_Ponomarev]

my bad, it's not an avary-landing.

From the JavaScript console:
Error: makeURI is not defined
Source File: chrome://browser/content/pageInfo.js
Line: 683

should be makeURL. This is a typo in Daniel Brooks's path <http://tinyurl.com/4cztv>

Comment 4

[Nickolay_Ponomarev]

Actually, not a typo in that patch, but the differences between Firefox and
Seamonkey.

And by the way, saveURL in Firefox accepts 6 args instead of seamonkey's 5.
http://lxr.mozilla.org/seamonkey/source/browser/base/content/contentAreaUtils.js#164

Comment 5

[Daniel Brooks [:db48x]]

bah

Comment 6

[Daniel Brooks [:db48x]]

Attachment: patch

Comment 7

[Mike Connor [:mconnor]]

Comment on attachment 169175 [details] [diff] [review]
patch

small little rap on ze knuckles for the lack of context, but otherwise r=me,
you probably can get sr/rs=neil, but he's not apt to review anything /browser

Comment 8

[[e-mail]]

Comment on attachment 169175 [details] [diff] [review]
patch

Ah, but you wanted rs=me for xpfe right? ;-)

Comment 9

[Mathieu Pellerin]

any chance it'll get in the trunk soon? the patch has been superreviewed already

Comment 10

[Daniel Brooks [:db48x]]

Mathieu: true, but the tree only just opened

anyway, I just checked it in

Comment 11

[Mathieu Pellerin]

thanks, was "refreshing" the bug ;)

Comment 12

[Daniel Veditz [:dveditz]]

assuming this is the bug corresponding to your Feb 4, 2005 checkin to the 1.7
branch (although patch doesn't match exactly and reviewers aren't marked).

Please include the bug number in your check-in comments.

Comment 13

[Daniel Veditz [:dveditz]]

my comments should have gone in bug 239472. Thanks for setting me straight, f.qu 

And the rest of you, see why bug numbers in checkin comments are a good idea? ;-)