275245 - Regenerate Customize Toolbar Icon for help viewer

Status: RESOLVED INVALID

(SeaMonkey :: Help Viewer, defect)

Description

[Jeff Walden (gone starting June 8)]

The Help viewer toolbar icon in Pinstripe for customizing the toolbar is based
off an older version of the Pinstripe theme (the one that had blue triangles for
forward/back).  A new version of it (with the newer green arrows instead) needs
to be created and put into the tree.

The toolbar icons for Help in Pinstripe:
http://lxr.mozilla.org/mozilla/source/toolkit/themes/pinstripe/help/Toolbar.png

The (newer) browser toolbar icons in Pinstripe:
http://lxr.mozilla.org/mozilla/source/browser/themes/pinstripe/browser/Toolbar.png

Comment 1

[Jeff Walden (gone starting June 8)]

This should be done for 1.1 for visual consistency.  Requesting
blocking-aviary1.1...

Comment 2

[Steffen Wilberg]

Flags got lost by the move to the Toolkit product. You have to rerequest
blocking-aviary1.1 if you want.

Comment 3

[Mike Connor [:mconnor]]

Can we just agree on a toolbar config and drop customization instead?  As
evil/nasty as this mockup is, I think its much close to the right thing than
what we have.  http://steelgryphon.com/stuff/Screenshot-Mozilla%20Firefox%20Help.png

Comment 4

[Kevin Gerich]

This bug is just one hair above WONTFIX. It shouldn't block anything. The
secondary icon element that Jeff is referring to is meant to represent a generic
toolbar. The "inconsistency" does not mean it's more difficult to understand the
meaning of the icon. Yeah I could make those little arrows greenish at some
point but it's not a priority. This is on my "to revisit up at some point" list
though.

Comment 5

[Jeff Walden (gone starting June 8)]

(In reply to comment #3)
> Can we just agree on a toolbar config and drop customization instead?

I've been thinking about the viewer UI over the past couple of months, and I'm
slowly gathering ideas together into something that's different from the current
impl and (at least in my head so far, without a whole lot of thought on the
matter) better.  I'll try to post a mockup of it sometime in the next few days
or so, probably with the opening of a new bug.

In the meantime however, I'm not sure this bug needs to be fixed.  Every other
toolbar gets along fine without a visible, non-menu item customize widget, and
since help won't be used nearly as much highlighting its customizability isn't
really worthwhile.  As a temporary move between now and some revised UI, I'm
perfectly fine with just removing the Customize Toolbar icon from the available
icon set and just rely on the user to right-click if customization is really
desired.

Comment 6

[Jeff Walden (gone starting June 8)]

Bug 295817 should make this bug INVALID, because we're eliminating toolbar
customization completely and going with sane, usable defaults.

Comment 7

[Jeff Walden (gone starting June 8)]

The icon is no longer needed now that bug 295817's fixed.