Closed Bug 275405 Opened 18 years ago Closed 18 years ago

create bookmark , folder name fails to appear in "create in" input field

Categories

(Firefox :: Bookmarks & History, defect)

x86
Windows 2000
defect
Not set
major

Tracking

()

VERIFIED FIXED
Firefox1.5

People

(Reporter: Peter6, Assigned: Gavin)

Details

(Keywords: regression)

Attachments

(1 file)

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a6) Gecko/20041210
Firefox/1.0+

still present in 20041220 nightly

repro:
1. Open a page
2. Goto [Bookmarks] -> Bookmark this page...
3. Select a folder, if need try a few folders
4. The Name of the selected folder does not appear in the "Create in:" input.
5. Press ok

Set ->Major
because of the confusing character of this bug

a. This happens to random folders, I'm not even sure that it is allways the same
b. The bookmark is created in the selected folder (nothing wrong there)
Confirming - Only the 'recently added into' folders (ie those in the dropdown
list) have their name displayed in the field.
Running Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a6) Gecko/20041218
Firefox/1.0+ zip
Branch zip isn't affected.
Keywords: regression
That would be bug 244624 wouldn't it?

Error: setting a property that has only a getter
Source File: chrome://browser/content/bookmarks/addBookmark2.js
Line: 205

where line 205 is

  gMenulist.label = BookmarksUtils.getProperty(gSelectedFolder, NC_NS+"Name");

Unfortunately, while I see that we aren't supposed to set <menulist>.label, I
don't quite see what we're supposed to do instead in that situation.
You should set the menulist.value or menulist.selectedItem so that the
corresponding label is the one you want.
Note that by comparison Windows combo boxes explicitly return CB_ERR if you try
to set the label; you must select an existing item (or no item at all).
Attached patch Patch 1Splinter Review
Replaces the last item in the list with the chosen item.
Assignee: vladimir+bm → gavin.sharp
Status: NEW → ASSIGNED
Attachment #169630 - Flags: review?(mconnor)
Whiteboard: [have patch]
Flags: blocking-aviary1.1?
checked in
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Flags: blocking-aviary1.1?
Resolution: --- → FIXED
Whiteboard: [have patch]
Target Milestone: --- → Firefox1.1
->Verified
Status: RESOLVED → VERIFIED
sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change
QA Contact: mconnor → bookmarks
You need to log in before you can comment on or make changes to this bug.