275405 - create bookmark , folder name fails to appear in "create in" input field

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a6) Gecko/20041210
Firefox/1.0+

still present in 20041220 nightly

repro:
1. Open a page
2. Goto [Bookmarks] -> Bookmark this page...
3. Select a folder, if need try a few folders
4. The Name of the selected folder does not appear in the "Create in:" input.
5. Press ok

Set ->Major
because of the confusing character of this bug

a. This happens to random folders, I'm not even sure that it is allways the same
b. The bookmark is created in the selected folder (nothing wrong there)

Comment 1

[Oliver Saier]

Confirming - Only the 'recently added into' folders (ie those in the dropdown
list) have their name displayed in the field.
Running Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a6) Gecko/20041218
Firefox/1.0+ zip
Branch zip isn't affected.

Comment 2

[Phil Ringnalda (:philor)]

That would be bug 244624 wouldn't it?

Error: setting a property that has only a getter
Source File: chrome://browser/content/bookmarks/addBookmark2.js
Line: 205

where line 205 is

  gMenulist.label = BookmarksUtils.getProperty(gSelectedFolder, NC_NS+"Name");

Unfortunately, while I see that we aren't supposed to set <menulist>.label, I
don't quite see what we're supposed to do instead in that situation.

Comment 3

[Aaron Leventhal]

You should set the menulist.value or menulist.selectedItem so that the
corresponding label is the one you want.

Comment 4

[[e-mail]]

Note that by comparison Windows combo boxes explicitly return CB_ERR if you try
to set the label; you must select an existing item (or no item at all).

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Attachment: Patch 1

Replaces the last item in the list with the chosen item.

Comment 6

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 169630 [details] [diff] [review]
Patch 1

r=[e-mail]

Comment 7

[Asaf Romano (gone)]

checked in

Comment 8

[Peter van der Woude [:Peter6]]

->Verified

Comment 9

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change