Closed
Bug 275457
Opened 21 years ago
Closed 21 years ago
embedding/browser/qt should not use nsIPref
Categories
(Core Graveyard :: Ports: Qt, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.8alpha6
People
(Reporter: Biesinger, Assigned: Biesinger)
References
Details
Attachments
(1 file)
|
4.42 KB,
patch
|
zack
:
review+
|
Details | Diff | Splinter Review |
nsIPref is deprecated (replaced by nsIPrefBranch/nsIPrefService).
this directory doesn't make any use of it anyway, it just gets it but never
calls any functions on it. the following patch removes it.
|
Assignee | |
Comment 1•21 years ago
|
||
Attachment #169248 -
Flags: review?(zack)
|
|
Assignee | |
Updated•21 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.8alpha6
|
||
Comment 2•21 years ago
|
||
Comment on attachment 169248 [details] [diff] [review]
patch
Right on. I missed that completely when I was removing nsIPref's from widget
and gfx. Looks good, thanks.
Attachment #169248 -
Flags: review?(zack) → review+
|
|
Assignee | |
Comment 3•21 years ago
|
||
thanks, checked in
(I also noticed that this patch missed two spots, which I also removed before
checking in; and I removed the pref REQUIRES line)
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•19 years ago
|
QA Contact: cbiesinger → ports-qt
|
||
Updated•17 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•