Closed Bug 275457 Opened 20 years ago Closed 20 years ago

embedding/browser/qt should not use nsIPref

Categories

(Core Graveyard :: Ports: Qt, defect)

Product:
Core Graveyard
Component:
Ports: Qt
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla1.8alpha6

People

(Reporter: Biesinger, Assigned: Biesinger)

References

Details

Attachments

(1 file)

patch
4.42 KB, patch
zack
: review+
Details | Diff | Splinter Review 
nsIPref is deprecated (replaced by nsIPrefBranch/nsIPrefService).

this directory doesn't make any use of it anyway, it just gets it but never
calls any functions on it. the following patch removes it.
Attached patch patch — — Splinter Review 

        Attachment #169248 -
        Flags: review?(zack)
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.8alpha6

    
    

    
  
Comment on attachment 169248 [details] [diff] [review]
patch

Right on. I missed that completely when I was removing nsIPref's from widget
and gfx. Looks good, thanks.

        Attachment #169248 -
        Flags: review?(zack) → review+

    
    

    
  
thanks, checked in

(I also noticed that this patch missed two spots, which I also removed before
checking in; and I removed the pref REQUIRES line)
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
QA Contact: cbiesinger → ports-qt
Product: Core → Core Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: