275737 - removing menulist children causes errors

Status: UNCONFIRMED

(Core :: XUL, defect)

Description

[Sean McMurray]

menulist.removechild(menulist.selectedItem) does not reset the value of
menulist. It retains its label, and errors the next time you click the dropdown.

Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE)
[nsIMenuBoxObject.activeChild]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)" 
location: "JS frame :: chrome://global/content/bindings/menulist.xml ::
onxblpopupshowing :: line 35"  data: no

Comment 1

[[e-mail]]

Removing the selected item is not nice in any widget...

So, any suggestions as to the "correct" fix?
1. Just bulletproof the activeChild logic
2. Write an XBL destructor for menuitems to deselect them
3. Write a C++ destructor for menuitems to deselect them

Comment 2

[Boris Zbarsky [:bzbarsky]]

I don't really know enough about how menulists are set up to tell which of those is best....

Comment 3

[Sean McMurray]

Would it be as simple as placing a destructor in
toolkit/content/widgets/menu.xml#menuitem-base ?

<destructor>
  if this.isSameNode(parentNode.selectedItem)
    parentNode.selectedIndex=-1;
</destructor>

Comment 4

[[e-mail]]

That is a (failed) attempt at case 2, yes...

Comment 5

[[e-mail]]

In an email bz seems to prefer option 3. This would involve adding a check to
the selectedItem getter to check that the item's parent is still the menulist.