275742 - enable e4x in JS components

Status: RESOLVED FIXED

(Core :: XPConnect, defect, P1)

Description

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

For the win, as it were.

Comment 1

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Attachment: enable JSOPTION_XML during compilation

Caveat: don't use eval("e4x-using-script") in your components.

Comment 2

[Brendan Eich [:brendan]]

Comment on attachment 169407 [details] [diff] [review]
enable JSOPTION_XML during compilation

Cool -- can you hold this bug open and I'll patch the engine to propagate
options along with version so that compiled scripts and functions can eval
freely?

/be

Comment 3

[Brendan Eich [:brendan]]

Attachment: fix JS engine to propagate JSOPTION_XML via script->version

See the comments in jscntxt.h for the subtle implications.  No need to rev the
script XDR magic number, or the XUL FastLoad file version, because existing
XDR'ed scripts have a version number without the JSVERSION_HAS_XML flag set. 
Zero high order bits => forward compatibility.

/be

Comment 4

[Brendan Eich [:brendan]]

A typo fix and rewording in the last paragraph of that big jscntxt.h comment:

 * Note also that script->version must contain this XML option flag in order
 * for XDR'ed scripts to serialize and deserialize with that option preserved
 * for detection at run-time.  We can't copy other compile-time options into
 * script->version because that would break backward compatibility (certain
 * other options, e.g. JSOPTION_VAROBJFIX, are analogous to JSOPTION_XML).

/be

Comment 5

[Brendan Eich [:brendan]]

Attachment: fix JS engine patch, v2

This avoids adding JSVERSION_MASK and JSVERSION_HAS_XML to jspubtd.h, which is
part of the public API.  So JS_SetVersion asserts that its version argument is
a well-defined version number (not unknown, no high-order flag bits).  It's a
pretty mechanical change to the last patch, so I'm imputing r=shaver.

/be

Comment 6

[Brendan Eich [:brendan]]

I checked in, so this goes back to shaver ;-).

/be

Comment 7

[Brendan Eich [:brendan]]

I checked in shaver's patch (attachment 169407 [details] [diff] [review]), so this bug is fixed.

/be