275828 - #ifdef MOZ_THUNDERBIRD statements in Extensions Manager hose Sunbird

Status: RESOLVED FIXED

(Toolkit :: Preferences, defect)

Description

[Matthew (lilmatt) Willis]

Sunbird uses toolkit, and should be able to install themes or extensions from a
file. #ifdef MOZ_THUNDERBIRD statements were used in Extensions Manager to allow
TB to install from a file. These should either be changed to #ifndef MOZ_PHOENIX
statements, or if we're being strict about no #if[n]def MOZ* statements in
toolkit, they should be removed altogether and Firefox should be able to install
from a file in addition to from a download.

Comment 1

[Matthew (lilmatt) Willis]

Attachment: rev0 - Changes #ifdef MOZ_THUNDERBIRD to #ifndef MOZ_PHOENIX

Comment 2

[Matthew (lilmatt) Willis]

Attachment: rev1 - trunk - alternative to rev0 - ifdefs removed

Alternatively, this patch removes those ifdefs altogether, giving Firefox the
ability to install extensions/themes from a file

Comment 3

[Matthew (lilmatt) Willis]

taking
sorry for bugspam

Comment 4

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 169448 [details] [diff] [review]
rev0 - Changes #ifdef MOZ_THUNDERBIRD to #ifndef MOZ_PHOENIX

I prefer rev0 - the "from a file" UI is a workaround to the fact that we have
no sane dispatching of different extension types from the browser which should
be fixed. r=[e-mail]

Comment 5

[Matthew (lilmatt) Willis]

(In reply to comment #4)
> (From update of attachment 169448 [details] [diff] [review] [edit])
> I prefer rev0 - the "from a file" UI is a workaround to the fact that we have
> no sane dispatching of different extension types from the browser which should
> be fixed. r=[e-mail]

rev0 patch checked in
-> FIXED