276112 - Can still leak nsExternalAppHandler/nsIDownload

Status: NEW

(Firefox :: File Handling, defect, P5)

Description

[Christian Persch (GNOME) (away; not receiving bug mail)]

Even with the fix from bug 152224, it's still possible that nsExternalAppHandler
and its nsIDownload are leaked, if the OnStopRequest is received _before_ the
nsIDownload is even created. See the analysis at 
http://bugzilla.gnome.org/show_bug.cgi?id=158217#c1 .

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

confirming and taking; maybe these refcycle-breaking code from
http://lxr.mozilla.org/seamonkey/source/uriloader/exthandler/nsExternalHelperAppService.cpp#1982
(OnStopRequest) should move to ExecuteDesiredAction; but that needs to be done
carefully since it's possible that that's releasing the last reference to the
apphandler, I think...

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

is bug 276112 related?

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

make that bug 343107

Comment 4

[Christian Persch (GNOME) (away; not receiving bug mail)]

Yes, that looks like the same problem, according to my analysis of the problem in http://bugzilla.gnome.org/show_bug.cgi?id=158217#c1 from comment 0.

Comment 5

[Dorian]

I have no leak related to bug 343107. Everything is correctly released after the return from SaveToDisk and the release of the HelperAppLauncherDialog which follows.

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

I'm still not sure why that caused a leak, but bug 343107 is fixed now. anything left to do here?

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Decreasing the priority as no update for the last 2 years on this bug.
See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage 
about the priority meaning.